Fix: Remove non-dismissable error message on the Expensify card page #75672

ryntgh · 2025-11-20T14:10:51Z

Explanation of Change

This PR remove non-dismissable error message on the card page and show it on the magic code page instead

Fixed Issues

$ #73134
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition:

User has assigned themselves a virtual card

Go to Account > Wallet
Click on the virtual card
Click Reveal details
Enter an incorrect magic code
Verify that the magic code error is displayed above the Verify button
Go back to the previous page
Verify that there is no error under the Reveal details button
Open Troubleshoot modal -> turn on Simulate failing network requests
Click Reveal details
Enter an incorrect magic code
Verify that the internet connection error is displayed above the Verify button
Repeat steps 6-7

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

codecov · 2025-11-20T14:18:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...pensifyCardPage/ExpensifyCardVerifyAccountPage.tsx	`0.00% <0.00%> (ø)`
... and 169 files with indirect coverage changes

melvin-bot · 2025-11-20T15:36:21Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

The UX feels weird on this one. Why does an error message show as soon as you enter the page?

CC: @joekaufmanexpensify for vis

bernhardoj · 2025-11-21T00:24:30Z

Why does an error message show as soon as you enter the page?

@trjExpensify I think it's the magic code send limit error

bernhardoj · 2025-11-21T00:52:29Z

src/pages/settings/Wallet/ExpensifyCardPage/ExpensifyCardVerifyAccountPage.tsx

-                    ...prevState,
-                    [cardID]: error,
-                }));
-                navigateBack();


I see that navigateBack was added from #68749. @MonilBhavsar if the user inputs a wrong magic code, they will be navigated back.

web.mp4

This is the previous behavior. The user stays on the magic code page.

web.mp4

In this PR, we want to keep the user on the magic code page and show any errors on the magic code page. Does that fine with you?

Fine with me, we implemented the fix because there was no error to display on the magic code page cc @joekaufmanexpensify

@ryntgh can you test #68749 on this PR and see if the error shown correctly?

@bernhardoj I couldn't really test this since I can't connect with an EU/UK bank account. But I noticed that the latest change in the PR was to automatically redirect to ROUTES.SETTINGS_WALLET_CARD_MISSING_DETAILS for EU/UK cards (I hardcoded this to US)

MacOS-Chrome.mp4

Since I can't use an EU/UK bank account, I couldn't confirm whether the missing personal details error message is shown correctly

@MonilBhavsar do you know how can I add a EU/UK bank account?

@ryntgh Btw, can you merge with main, please?

Done, merged with the latest main!

@ryntgh I get this error when trying to simulate the missing details error.

You can try rejecting the promise in revealVirtualCardDetails.
reject('cardPage.missingPrivateDetails');

@ryntgh after thinking more about it, I think it's better to keep the previous logic if the error is 'cardPage.missingPrivateDetails' because it's not a magic code error. What do you think?

@bernhardoj Yeah, I agree. Keeping the previous logic for that case seems like the better approach

joekaufmanexpensify · 2025-11-21T13:26:28Z

The UX feels weird on this one. Why does an error message show as soon as you enter the page?

I agree with @trjExpensify. Sounds like you're saying the video you uploaded for testing with the magic code send limit error is not actually representative of what the user will normally see @bernhardoj. Is that right?

bernhardoj · 2025-11-21T13:52:23Z

@joekaufmanexpensify in most cases, yes. It only happens if the user has requested too many times, and in this case, @ryntgh recorded in that state.

bernhardoj · 2025-11-26T00:20:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

bernhardoj

LGTM

bernhardoj · 2025-12-01T04:37:19Z

@danieldoglas ready for your review

Fix: Remove non-dismissable error message on the card page

d62709d

melvin-bot bot assigned ryntgh Nov 20, 2025

ryntgh changed the title ~~Fix: Remove non-dismissable error message on the card page~~ Fix: Remove non-dismissable error message on the Expensify card page Nov 20, 2025

ryntgh marked this pull request as ready for review November 20, 2025 15:36

ryntgh requested review from a team as code owners November 20, 2025 15:36

melvin-bot bot requested review from bernhardoj and removed request for a team November 20, 2025 15:36

melvin-bot bot requested review from trjExpensify and removed request for a team November 20, 2025 15:36

ryntgh mentioned this pull request Nov 20, 2025

[$500] Expensify Card - Magic code error does not appear above Verify button when revealing details #73134

Open

16 tasks

trjExpensify requested changes Nov 20, 2025

View reviewed changes

bernhardoj reviewed Nov 21, 2025

View reviewed changes

ryntgh added 2 commits November 25, 2025 11:31

Merge branch 'main' into issue/73134

30c31de

Fix: Remove non-dismissable error message on the Expensify card page

25c91df

bernhardoj approved these changes Nov 26, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas November 26, 2025 00:33

Fix: Remove non-dismissable error message on the Expensify card page #75672

Are you sure you want to change the base?

Fix: Remove non-dismissable error message on the Expensify card page #75672

Conversation

ryntgh commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 20, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Nov 21, 2025

Uh oh!

bernhardoj commented Nov 21, 2025

Uh oh!

bernhardoj commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ryntgh commented Nov 20, 2025 •

edited

Loading

codecov bot commented Nov 20, 2025 •

edited by github-actions bot

Loading

bernhardoj Nov 25, 2025 •

edited

Loading

bernhardoj Nov 25, 2025 •

edited

Loading

bernhardoj commented Nov 26, 2025 •

edited

Loading