linr

Expensify · Jan 31, 2025 · a984e7f · a984e7f
1 parent 689c8d8
commit a984e7f
Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/__mocks__/@react-navigation/native/index.ts b/__mocks__/@react-navigation/native/index.ts
@@ -44,6 +44,7 @@ const useLinkTo = isJestEnv ? realReactNavigation.useLinkTo : () => null;
 const useScrollToTop = isJestEnv ? realReactNavigation.useScrollToTop : () => null;
 const useRoute = isJestEnv ? jest.fn() : () => ({params: {}});
 const useFocusEffect = isJestEnv ? realReactNavigation.useFocusEffect : (callback: () => void) => callback();
+// eslint-disable-next-line @typescript-eslint/naming-convention
 const UNSTABLE_usePreventRemove = isJestEnv ? jest.fn() : () => {};
 
 export {

diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx
@@ -386,7 +386,6 @@ function BaseSelectionList<TItem extends ListItem>(
         [
             canSelectMultiple,
             sections.length,
-            flattenedSections.selectedOptions.length,
             scrollToIndex,
             shouldShowTextInput,
             clearInputAfterSelect,

diff --git a/tests/ui/NewChatPageTest.tsx b/tests/ui/NewChatPageTest.tsx
@@ -11,7 +11,7 @@ import {translateLocal} from '@libs/Localize';
 import NewChatPage from '@pages/NewChatPage';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {NativeNavigationMock} from '../../__mocks__/@react-navigation/native';
-import createPersonalDetails from '../utils/collections/personalDetails';
+import {fakePersonalDetails} from '../utils/LHNTestUtils';
 import waitForBatchedUpdatesWithAct from '../utils/waitForBatchedUpdatesWithAct';
 
 jest.mock('@react-navigation/native');
@@ -24,13 +24,7 @@ describe('NewChatPage', () => {
     });
 
     it('should scroll to top when adding a user to the group selection', async () => {
-        await Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {
-            1: createPersonalDetails(1),
-            2: createPersonalDetails(2),
-            3: createPersonalDetails(3),
-            4: createPersonalDetails(4),
-            5: createPersonalDetails(5),
-        });
+        await Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, fakePersonalDetails);
         render(
             <OnyxProvider>
                 <LocaleContextProvider>

diff --git a/tests/unit/BaseSelectionListTest.tsx b/tests/unit/BaseSelectionListTest.tsx
@@ -64,7 +64,7 @@ describe('BaseSelectionList', () => {
         expect(screen.getByTestId(`${CONST.BASE_LIST_ITEM_TEST_ID}2`)).toBeSelected();
     });
 
-    it('should scroll to top when selecting a multi option list', async () => {
+    it('should scroll to top when selecting a multi option list', () => {
         const spy = jest.spyOn(SectionList.prototype, 'scrollToLocation');
         render(
             <BaseListItemRenderer