Skip to content

Commit

Permalink
Use new npm command and fastfile
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewGable committed Jan 28, 2025
1 parent 463e3eb commit 53623ba
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/verifyHybridApp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,7 @@ jobs:
export RCT_NO_LAUNCH_PACKAGER=1
# Build iOS using xcodebuild
if ! xcodebuild \
-workspace Mobile-Expensify/iOS/Expensify.xcworkspace \
-scheme Expensify \
-configuration Debug \
-sdk iphonesimulator \
-arch x86_64 \
CODE_SIGN_IDENTITY="" \
CODE_SIGNING_REQUIRED=NO \
CODE_SIGNING_ALLOWED=NO \
build | xcpretty
if ! npm run ios-hybrid-build
then
echo "❌ iOS HybridApp failed to build: Please reach out to Contributor+ and/or Expensify engineers for help in #expensify-open-source to resolve."
exit 1
Expand Down
10 changes: 8 additions & 2 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,10 @@ platform :ios do
ENV["ENVFILE"]=".env.production"
build_app(
workspace: "./ios/NewExpensify.xcworkspace",
scheme: "New Expensify"
scheme: "New Expensify",
configuration: "Debug",
sdk: "iphonesimulator",
skip_codesigning: true
)
setIOSBuildOutputsInEnv()
end
Expand All @@ -468,7 +471,10 @@ platform :ios do
ENV["ENVFILE"]="./Mobile-Expensify/.env.production.hybridapp.ios"
build_app(
workspace: "./Mobile-Expensify/iOS/Expensify.xcworkspace",
scheme: "Expensify"
scheme: "Expensify",
configuration: "Debug",
sdk: "iphonesimulator",
skip_codesigning: true
)
setIOSBuildOutputsInEnv()
end
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"detectRedirectCycle": "ts-node .github/scripts/detectRedirectCycle.ts",
"desktop-build-adhoc": "./scripts/build-desktop.sh adhoc",
"ios-build": "bundle exec fastlane ios build_unsigned",
"ios-hybrid-build": "bundle exec fastlane ios build_unsigned_hybrid",
"android-build": "bundle exec fastlane android build_local",
"test": "TZ=utc NODE_OPTIONS=--experimental-vm-modules jest",
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
Expand Down

0 comments on commit 53623ba

Please sign in to comment.