Refactor shouldFetchReport function to reduce updates

src/libs/shouldFetchReport.ts

@@ -1,9 +1,8 @@
 import type {OnyxEntry} from 'react-native-onyx';
 import type Report from '@src/types/onyx/Report';
-import type ReportMetadata from '@src/types/onyx/ReportMetadata';
 
-export default function shouldFetchReport(report: OnyxEntry<Report>, reportMetadata: OnyxEntry<ReportMetadata>) {
+export default function shouldFetchReport(report: OnyxEntry<Report>, isOptimisticReport?: boolean) {
     // If the report is optimistic, there's no need to fetch it. The original action should create it.
     // If there is an error for creating the chat, there's no need to fetch it since it doesn't exist
-    return !reportMetadata?.isOptimisticReport && !report?.errorFields?.createChat;
+    return !isOptimisticReport && !report?.errorFields?.createChat;
 }

src/pages/home/ReportScreen.tsx

@@ -518,7 +518,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
             return;
         }
 
-        if (!shouldFetchReport(report, reportMetadata)) {
+        if (!shouldFetchReport(report, reportMetadata.isOptimisticReport)) {
             return;
         }
         // When creating an optimistic report that already exists, we need to skip openReport
@@ -529,7 +529,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
         }
 
         fetchReport();
-    }, [reportIDFromRoute, isLoadingApp, report, reportMetadata, fetchReport]);
+    }, [reportIDFromRoute, isLoadingApp, report, fetchReport, reportMetadata]);
 
     const dismissBanner = useCallback(() => {
         setIsBannerVisible(false);
@@ -575,8 +575,9 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
             return;
         }
         fetchReportIfNeeded();
+        console.log('fetchReportIfNeeded');
         // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
-    }, [isLoadingReportOnyx]);
+    }, [isLoadingReportOnyx, fetchReportIfNeeded]);
 
     useEffect(() => {
         if (isLoadingReportOnyx || !reportActionIDFromRoute || isLinkedMessagePageReady) {

src/pages/home/report/ReportActionsView.tsx

@@ -118,7 +118,7 @@ function ReportActionsView({
     const reportID = report.reportID;
     const isReportFullyVisible = useMemo((): boolean => getIsReportFullyVisible(isFocused), [isFocused]);
     const openReportIfNecessary = () => {
-        if (!shouldFetchReport(report, reportMetadata)) {
+        if (!shouldFetchReport(report, reportMetadata?.isOptimisticReport)) {
             return;
         }