Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all usage of new Buffer(); use Buffer.from()/Buffer.alloc() #1

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Remove all usage of new Buffer(); use Buffer.from()/Buffer.alloc() #1

merged 1 commit into from
Jun 19, 2020

Conversation

RyanZim
Copy link

@RyanZim RyanZim commented Jun 18, 2020

unidwell
unidwell approved these changes Jun 19, 2020
View reviewed changes
Copy link

@unidwell unidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

One observation. The engines.node version set in package.json is too low. Node versions < 4.x don't have Buffer.alloc method.

@RyanZim
Copy link
Author

RyanZim commented Jun 19, 2020

The engines.node version set in package.json is too low. Node versions < 4.x don't have Buffer.alloc method.

Good point; fixed in e7f21d3

@RyanZim RyanZim merged commit ff980ee into exodus Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unidwell unidwell unidwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanZim @unidwell