Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] style(megabench): improve code formatting and import ordering #497

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

Luodian
Copy link
Contributor

@Luodian Luodian commented Jan 13, 2025

  • re-order imports based on PEP 8
  • remove unnecessary blank lines
  • format tuples and lists to be more concise
  • apply consistent string formatting across files

♻️ refactor(megabench): optimize loop and conditional structures

  • refactor match-case statements for Python 3.9 compatibility
  • optimize list comprehensions for improved performance
  • simplify nested conditionals for better readability

Before you open a pull-request, please check if a similar issue already exists or has been closed before.

When you open a pull-request, please be sure to include the following

  • A descriptive title: [xxx] XXXX
  • A detailed description

If you meet the lint warnings, you can use following scripts to reformat code.

pip install pre-commit
pre-commit install
pre-commit run --all-files

Thank you for your contributions!

- re-order imports based on PEP 8
- remove unnecessary blank lines
- format tuples and lists to be more concise
- apply consistent string formatting across files

♻️ refactor(megabench): optimize loop and conditional structures

- refactor match-case statements for Python 3.9 compatibility
- optimize list comprehensions for improved performance
- simplify nested conditionals for better readability
- convert single-line import statements to multi-line format using parentheses for better readability
- remove unnecessary blank lines to improve code consistency
@Luodian Luodian changed the title style(megabench): improve code formatting and import ordering [WIP] style(megabench): improve code formatting and import ordering Jan 13, 2025
- import time module for timestamp generation
- append timestamp to submission file names for uniqueness and traceability
@Luodian Luodian requested a review from pufanyi January 14, 2025 16:56
@pufanyi pufanyi merged commit 50ed3ce into main Jan 15, 2025
2 checks passed
@pufanyi pufanyi deleted the fix/megabench_linting branch January 15, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants