[Model] support cogvlm2 model #261
Conversation
lmms_eval/models/minimonkey.py
Outdated
There was a problem hiding this comment.
Hi @white2018 , is this a duplicate commit? Remember that you have add this model in the previous PR
There was a problem hiding this comment.
Sorry! It is a wrong commit. Forget about it.
@kcz358 This commit about minimonkey model is just a mistake. Sorry about that. |
|
Hi @white2018 , you mind if I try rebase and drop the duplicated commits on you branch? |
OK, I try it. |
|
Thank you! @white2018 , I can also help you do it if you don't have time to do so. Since I can edit on this PR branch, I can directly push to this branch that stick to this PR in your forked repo. |
@kcz358 That will be appreciated. Thanks a lot! |
|
Hi @white2018 , I have drop the duplicate commits and rebase to main. Can you help me do a final code check to see if I did not accidentally dropped any code changes? If the current change is good, I will merge this PR. Thank you for your contribution! |
@kcz358 Everything is OK |
Before you open a pull-request, please check if a similar issue already exists or has been closed before.
When you open a pull-request, please be sure to include the following
Thank you for your contributions!
This PR intends to enhance the functionality of lmms-eval by supporting CogVLM2 model, which is not covered in latest version.
The code is evaluated with mmstar dataset. Here is the screeshot as follows:
