-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for complex number #374
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 75.47% 75.63% +0.16%
==========================================
Files 32 32
Lines 5137 5332 +195
==========================================
+ Hits 3877 4033 +156
- Misses 1260 1299 +39 ☔ View full report in Codecov by Sentry. |
Other than those things, this LGTM |
I just noticed that the |
I made the change anyway, let me know what you think |
Thanks, I think that makes sense. I had envisaged the summary_type for where there was a more specialised type based on an SQLite type that we also use, e.g. timestamps stored as floats, but I don't see any problems with using it for custom bytes types as well. LGTM |
+1 to putting the complex data type to Also, LGTM. Thanks for adding the tests! |
thanks both for the review! |
HED needs to save complex number for their next experiment.
h5py does support saving complex numbers, but netCDF does not yet, there's an option in xarrays's
to_netcdf
to save "invalid netCDF" files allowing these features, c.f. https://docs.xarray.dev/en/stable/user-guide/io.html#invalid-netcdf-filesI understand this PR in HDF5 would allow support for these data types in netCDF, but it's not clear when it will be available.