feat(api): use factory function for creating app, add structlog #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertRosca
changed the title
An error occurred while trying to automatically change base from
fix/types-warnings
to
main
October 29, 2024 09:24
RobertRosca
force-pushed
the
feat/logging-app-factory
branch
from
86af686 to
9244367
Compare
CammilleCC
approved these changes
Oct 29, 2024
not really reliable given we run in container/front of reverse proxy
names should not have space
|
@CammilleCC thanks for the review, addressed your comments and made a few changes, could you have a look at those as well? |
|
LGTM x 2, thanks for the changes and clarifications! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging via structlog, uses an uvicorn app factory instead of direct references to a
main.appobject (works better when using hot reload).NB: should be merged to main after #33