Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - Trade Id #15

Merged
merged 27 commits into from
Nov 8, 2024
Merged

V3 - Trade Id #15

merged 27 commits into from
Nov 8, 2024

Conversation

Estecka
Copy link
Owner

@Estecka Estecka commented Nov 6, 2024

  • Removed trade cache. Upgrading from v2 will cause cached maps to be discarded.
  • Trades can now be marked a persistent by their factories. Persistent trades are never rerolled until the item has been sold. Filled map trades are automatically marked as persistent regardless of the factories setting.
  • Trades can now be given an identifier by their factories. This is used to associate a trade offer to its factory, and prevent duplicatas from being created.
  • It's overall easier for other modded factories to communicate with ShiftingWares. Factories only need to implement the proper getters, without requiring a dependency on ShiftingWares.

Fixes:

@Estecka Estecka changed the title V3 V3 - Trade Id Nov 8, 2024
@Estecka Estecka merged commit 23746db into 1.21.3 Nov 8, 2024
1 check passed
@Estecka Estecka deleted the v3-dev branch November 8, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant