Skip to content

Commit

Permalink
Marked as incompatible with MC1.20.5
Browse files Browse the repository at this point in the history
  • Loading branch information
Estecka committed Apr 25, 2024
1 parent 407b15b commit 4c29e92
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 25 deletions.
17 changes: 7 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,26 @@ jobs:
matrix:
# Use these Java versions
java: [
17, # Current Java LTS & minimum supported by Minecraft
17, # Minimum supported by target version of Minecraft
]
# and run on both Linux and Windows
os: [ubuntu-22.04, windows-2022]
runs-on: ${{ matrix.os }}
runs-on: ubuntu-22.04
steps:
- name: checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: validate gradle wrapper
uses: gradle/wrapper-validation-action@v1
uses: gradle/wrapper-validation-action@v2
- name: setup jdk ${{ matrix.java }}
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'microsoft'
- name: make gradle wrapper executable
if: ${{ runner.os != 'Windows' }}
run: chmod +x ./gradlew
- name: build
run: ./gradlew build
- name: capture build artifacts
if: ${{ runner.os == 'Linux' && matrix.java == '17' }} # Only upload artifacts built from latest java on one OS
uses: actions/upload-artifact@v3
if: ${{ matrix.java == '17' }} # Only upload artifacts built from latest java
uses: actions/upload-artifact@v4
with:
name: Artifacts
path: build/libs/
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
contents: write
steps:
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: Artifacts
path: ./
Expand Down
14 changes: 6 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
# Data-Pack / Game-Rule Menus

Makes the eponymous menus accessible from the pause menu in singleplayer worlds.
Makes the titular menus accessible from the pause menu in singleplayer worlds.

## Word of caution: Datapacks

Some built-in datapacks are not "just" datapacks, and require special handling. A warning screen will be shown whenever you attempt to enable or disable any of these, and give you the option to back out.
## Word of caution: Datapacks

### Feature Packs
Minecraft's own built-in datapacks are not "just" datapacks, and require special handling. A warning screen will be shown whenever you attempt to toggle any of these, and give you the option to back out.

### Experimental Feature
When packs that include experimental features (such as bundles) are toggled, the approriate feature flag will be toggled on the world.

However, **unlike regular datapacks those will not take effect until you restart the world.** If you had to go through a warning screen in order to toggle something, you'll probably want to restart the world immediately.
However, **unlike regular datapacks, those won't fully take effect until the world is restarted.** After you confirm the changes, the world will immediately exit.

### Vanilla Datapack

The vanilla datapack can technically be disabled, but doing so will break worlds most of the times. The uses cases for this are very marginal, so you probably don't want to do it.

The Vanilla datapack can technically be disabled, but the uses cases for this are very marginal. Doing so will break worlds most of the times, so you probably don't want to do it.
An additional warning screen will appear when trying to disable this pack.

If you can't load a world after having disabled the Vanilla datapack, loading it in Safe Mode should be able to restore it.
3 changes: 3 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@
- Integration for Cloth Gamerules screen.
### 1.2.1
- Fix Mixin searching for ClotGamerules classes when not installed.
### 1.2.2
- Updated for MC1.20.5.
- In 1.20.5, the position of the buttons in the option menu has changed slightly.
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ loader_version=0.15.7
fabric_version=0.91.0+1.20.1

# Mod Properties
mod_version=1.2.1
mod_version=1.2.2
maven_group=tk.estecka.packrulemenus
archives_base_name=packrule-menus

# Optional Dependencies
clothGamerules_version=1.0.0+1.19.4
cloth_version=10.1.117
cloth_version=11.1.118
11 changes: 10 additions & 1 deletion port.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,13 @@
Current master

### 1.20.0
- `MatrixStack` parameters are replaced with `DrawContext` in most GUI.
#### No Workarounds:
- `MatrixStack` parameters are replaced with `DrawContext` in most GUI.

### 1.20.5
#### No Workaround:
- The option screen's layout has changed, causing custom buttons to appear in a different place.
- `WarningScreen::initButtons` was replaced with `getLayout`.
#### Possible Workaround:
- `ResourcePackManager::getEnabledNames` was renamed to `getEnabledIds` (Yarn Mappings changes)
- `MinecraftServer::createDataPackSettings` now takes an extra parameter: The function is simple enough to be reimplemented locally.
4 changes: 1 addition & 3 deletions src/main/resources/fabric.mod.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@
"packrule-menus.mixins.json"
],
"depends": {
"minecraft": "^1.20.0",
"minecraft": ">=1.20.0 <1.20.5",
"fabricloader": ">=0.15.3",
"java": ">=17"
},
"suggests": {
}
}

0 comments on commit 4c29e92

Please sign in to comment.