Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Show grid #412

Merged
merged 16 commits into from
May 23, 2024
Merged

[New] Show grid #412

merged 16 commits into from
May 23, 2024

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented May 16, 2024

Description

This PR implements Show grid in Maps category.
URL to README

Linked Issue(s)

  • swift/issues/5370

How To Test

Try all combinations of the settings.

Screenshots

screenshot

To Discuss

  1. The color picker initial states are not totally correct. Because for some grid types, each level of detail has different symbols, and it is hard to grab the right color for the current level. Since we don't need to fine tune the colors, I'll leave it inconsistent.

@yo1995 yo1995 self-assigned this May 16, 2024
@yo1995 yo1995 requested review from a team, dfeinzimer and zkline101 and removed request for a team May 17, 2024 00:06
dfeinzimer
dfeinzimer previously approved these changes May 17, 2024
Shared/Samples/Show grid/ShowGridView.swift Outdated Show resolved Hide resolved
Shared/Samples/Show grid/ShowGridView.swift Outdated Show resolved Hide resolved
Shared/Samples/Show grid/ShowGridView.swift Outdated Show resolved Hide resolved
zkline101
zkline101 previously approved these changes May 22, 2024
dfeinzimer
dfeinzimer previously approved these changes May 23, 2024
@yo1995 yo1995 dismissed stale reviews from dfeinzimer and zkline101 via 05a388d May 23, 2024 17:15
@yo1995
Copy link
Collaborator Author

yo1995 commented May 23, 2024

Yikes! I have to resolve merge conflict again. Since there is no other changes, I'll bypass the 2 approving reviews to directly merge this.

@yo1995 yo1995 merged commit 93fbd55 into v.next May 23, 2024
1 check failed
@yo1995 yo1995 deleted the Ting/New-ShowGrid branch May 23, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants