Skip to content

perf(pcs): Optimize polynomial evaluation with cache-friendly algorithm #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

closes: #

This PR:

  • Optimizes polynomial evaluation in horner_evaluate function with a cache-friendly algorithm
  • Improves performance for large polynomials by processing them in chunks
  • Reduces redundant calculations by pre-computing powers of evaluation points

This PR does not:

  • Implement the full FFT-based batch evaluation mentioned in TODO comments
  • Address other performance optimizations in the codebase

Key places to review:

  • pcs/src/poly.rs, horner_evaluate function - optimized algorithm with chunking approach

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests (N/A - optimization preserves existing behavior, covered by existing tests)
  • Updated relevant documentation in the code
  • Added relevant changelog entries to the CHANGELOG.md of touched crates. (N/A - minor optimization)
  • Re-reviewed Files changed in the GitHub PR explorer

@VolodymyrBg VolodymyrBg requested a review from alxiong as a code owner March 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant