Compatibility with ggplot2 3.6.0 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks for adapting the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Apologies for not posting an issue first.
The ggplot2 package is planning an update for around may 2025 and a reverse dependency test (tidyverse/ggplot2#6287) has shown that the next version of ggplot2 is incompatible with the divent package.
This PR makes a few changes that fixes compatibility, which you can test yourself with the development version of ggplot2 (
pak::pak("tidyverse/ggplot2")).In the new version the
default_aesfields are dynamic instead of static, which violates some assumptions in divent.Best,
Teun