Skip to content

RuntimeActivity: use extra_rt as a part of the conditional execute na…#2991

Open
wsmoses wants to merge 2 commits intomainfrom
ert
Open

RuntimeActivity: use extra_rt as a part of the conditional execute na…#2991
wsmoses wants to merge 2 commits intomainfrom
ert

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Mar 7, 2026

…me key

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/gradientutils.jl b/src/gradientutils.jl
index 811782cd..e0dd14d5 100644
--- a/src/gradientutils.jl
+++ b/src/gradientutils.jl
@@ -136,8 +136,8 @@ function get_or_insert_conditional_execute!(fn::LLVM.Function; force_run=false,
     newname = newname * LLVM.name(fn)
     cfn, _ = get_function!(mod, newname, FT)
     if !isa(cfn, LLVM.Function)
-	    message = "Failed to find function for $newname, types $(string(FT)), found $(string(cfn)), from $(string(operands(cfn)[1])), fn=$(string(fn))"
-	    throw(AssertionError(message))
+        message = "Failed to find function for $newname, types $(string(FT)), found $(string(cfn)), from $(string(operands(cfn)[1])), fn=$(string(fn))"
+        throw(AssertionError(message))
     end
     if isempty(blocks(cfn))
         linkage!(cfn, LLVM.API.LLVMInternalLinkage)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Benchmark Results

main a4198e6... main / a4198e6...
basics/make_zero/namedtuple 0.0519 ± 0.0022 μs 0.0528 ± 0.0024 μs 0.983 ± 0.062
basics/make_zero/struct 0.261 ± 0.0052 μs 0.259 ± 0.0053 μs 1 ± 0.029
basics/overhead 4.33 ± 0.01 ns 4.34 ± 0.01 ns 0.998 ± 0.0033
basics/remake_zero!/namedtuple 0.223 ± 0.008 μs 0.225 ± 0.0095 μs 0.993 ± 0.055
basics/remake_zero!/struct 0.227 ± 0.0082 μs 0.226 ± 0.01 μs 1 ± 0.058
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.23 μs 10.4 ± 2.1 μs 0.997 ± 0.2
fold_broadcast/multidim_sum_bcast/2D 12.4 ± 0.22 μs 12.4 ± 0.25 μs 0.998 ± 0.027
time_to_load 1.04 ± 0.0015 s 1.09 ± 0.017 s 0.953 ± 0.015

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/22799451252/artifacts/5811318743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant