Add RTLD_DEEPBIND existence check (fix builds on Alpine Linux) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for `RTLD_DEEPBIND` directly, rather than checking for `__APPLE__` and `__FreeBSD__` This was causing build failures in Alpine Linux, which uses `musl` instead of `glibc` and does not include `RTLD_DEEPBIND`: https://git.musl-libc.org/cgit/musl/tree/include/dlfcn.h
aiwebb
changed the title
|
This could fix compilation in the official Postgres Docker image. Can we please get this improvement reviewed/merged? @jeevanchalke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187.
Checks for
RTLD_DEEPBINDdirectly, rather than checking for__APPLE__and__FreeBSD__This was causing build failures in Alpine Linux, which uses
muslinstead ofglibcand does not includeRTLD_DEEPBIND:https://git.musl-libc.org/cgit/musl/tree/include/dlfcn.h