Skip to content

Correct VIP timeout property reference#7121

Merged
anjali-edb merged 1 commit intodevelopfrom
efm/correct-property-vip-check-timeout
Mar 27, 2026
Merged

Correct VIP timeout property reference#7121
anjali-edb merged 1 commit intodevelopfrom
efm/correct-property-vip-check-timeout

Conversation

@EFM-Bobby
Copy link
Copy Markdown
Contributor

Updated reference from 'node.timeout' to 'check.vip.timeout' for clarity on VIP checks during failover.

@EFM-Bobby EFM-Bobby requested a review from a team as a code owner March 24, 2026 11:18
@EFM-Bobby EFM-Bobby added the deploy Add this label to a PR and it will automatically be deployed to netlify label Mar 24, 2026
@EFM-Bobby
Copy link
Copy Markdown
Contributor Author

I added the 'deploy' label to make sure the link I changed works.

@EFM-Bobby
Copy link
Copy Markdown
Contributor Author

@andressa-steffens-edb Can you double check this change? The property was added in EFM-1590, back in version 5.1, and I apparently missed this reference to the old property that was used.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

@github-actions github-actions bot temporarily deployed to pull request March 24, 2026 11:25 Inactive
@andressa-steffens-edb
Copy link
Copy Markdown
Contributor

andressa-steffens-edb commented Mar 24, 2026

@andressa-steffens-edb Can you double check this change? The property was added in EFM-1590, back in version 5.1, and I apparently missed this reference to the old property that was used.

Looks good! I just checked and confirmed we're using check.vip.timeout now for the VIP retries.

Updated reference from 'node.timeout' to 'check.vip.timeout' for clarity on VIP checks during failover.
@anjali-edb anjali-edb force-pushed the efm/correct-property-vip-check-timeout branch from 5033c94 to 84cfeb7 Compare March 27, 2026 14:38
@github-actions github-actions bot temporarily deployed to pull request March 27, 2026 14:45 Inactive
Copy link
Copy Markdown
Contributor

@anjali-edb anjali-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anjali-edb anjali-edb merged commit e4f71d3 into develop Mar 27, 2026
8 checks passed
@anjali-edb anjali-edb deleted the efm/correct-property-vip-check-timeout branch March 27, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy Add this label to a PR and it will automatically be deployed to netlify oncall

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants