fix autocluster example #5601
Merged
fix autocluster example #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example had timestamptz as datatype and inserted only hour:minute unquoted. Besides the obvious quoting, we should either change the data to match the datatype, or the datatype to match the hour:minute data. Using full timestamptz probably wouldn't improve the example, which is well served by simple data. So using `time` as column datatype is adequate.
tureba
requested review from
piano35-edb,
gvasquezvargas and
nidhibhammar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example had timestamptz as datatype and inserted only hour:minute unquoted.
Besides the obvious quoting, we should either change the data to match the datatype, or the datatype to match the hour:minute data. Using full timestamptz probably wouldn't improve the example, which is well served by simple data. So using
timeas column datatype is adequate.This intends to cover issue #5486 .