Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs 146 clarify which configuration are at group or node l #5549

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

djw-m
Copy link
Contributor

@djw-m djw-m commented Apr 26, 2024

What Changed?

Reference fix with tables for alter_node_group_option that detail top or sub-group or all.

@djw-m djw-m self-assigned this Apr 26, 2024
@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Apr 26, 2024
@djw-m djw-m force-pushed the DOCS-146-clarify-which-configuration-are-at-group-or-node-l branch from a4b33e3 to c9af31d Compare April 26, 2024 10:05
Copy link
Contributor

github-actions bot commented Apr 26, 2024

@github-actions github-actions bot temporarily deployed to pr-5549-docs-146-clarify-which-configuration-are-at-group-or-node-l April 26, 2024 10:21 Inactive
@djw-m djw-m requested a review from Rahila April 26, 2024 15:31
@djw-m djw-m force-pushed the DOCS-146-clarify-which-configuration-are-at-group-or-node-l branch from c9af31d to 92f29b5 Compare April 30, 2024 18:50
@github-actions github-actions bot temporarily deployed to pr-5549-docs-146-clarify-which-configuration-are-at-group-or-node-l April 30, 2024 18:55 Inactive
Signed-off-by: Dj Walker-Morgan <[email protected]>
| `num_writers` | Number of parallel writers for the subscription backing this node group. Valid values are either `-1` or a positive integer. `-1` means the value specified by the GUC `bdr.writers_per_subscription` is used. `-1` is the default. Applies to top-level group only.|
| `enable_wal_decoder` | Enables/disables the decoding worker process. You can't enable the decoding worker process if `streaming_mode` is already enabled. Valid values are either `on` or `off`. Default is `off`. Applies to top-level group only.|
| `streaming_mode` | Enables/disables streaming of large transactions. When set to `off`, streaming is disabled. When set to any other value, large transactions are decoded while they're still in progress, and the changes are sent to the downstream. If the value is set to `file`, then the incoming changes of streaming transactions are stored in a file and applied only after the transaction is committed on upstream. If the value is set to `writer`, then the incoming changes are directly sent to one of the writers, if available. If parallel apply is disabled or no writer is free to handle streaming transaction, then the changes are written to a file and applied after the transaction is committed. If the value is set to `auto`, PGD tries to intelligently pick between `file` and `writer`, depending on the transaction property and available resources. You can't enable `streaming_mode` if the WAL decoder is already enabled.<br/><br/>For more details, see [Transaction streaming](../transaction-streaming). Applies to top-level group only.|
| `default_commit_scope` | The commit scope to use by default, initially the `local` commit scope. This applies only to the top-level node group. You can use individual rules for different origin groups of the same commit scope. See [Origin groups](../durability/commit-scopes/#origin-groups) for more details. |
Copy link
Contributor

@Rahila Rahila May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can say that this is supported for subgroups as well. However, the support is not straightforward and would need some more explanation as pointed by Vaijayanti here : https://enterprisedb.atlassian.net/browse/BDR-4947

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement "applies to toplevel node-group" needs correction.
Could you create a reference here to the explanation on:
https://enterprisedb.atlassian.net/browse/BDR-4947
that you would put in docs? Is it in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is not in this PR, but someone is going to have to explain to me why I'm being told conflicting things. I was told that the functions in the older bdr.alter_node_group_config( did not work for subgroups.

Now, back up at line 38 is the same statement which I assume is wrong now.

But someone is going to have to clarify (ie not just say "that is wrong") what the functionality of default_commit_scope is and how it differs between the two calls, assuming that is actually a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants