Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/poc/newinfobox - NOT FOR DEPLOYMENT #5529

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

djw-m
Copy link
Contributor

@djw-m djw-m commented Apr 23, 2024

What Changed?

Experimental new info box for pages. Works on PGD, milage elsewhere may vary depending on where release notes are.

@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Apr 23, 2024
@djw-m djw-m requested a review from josh-heyer April 23, 2024 16:44
@djw-m djw-m self-assigned this Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

@github-actions github-actions bot temporarily deployed to pr-5529-docs-poc-newinfobox April 23, 2024 17:01 Inactive
@github-actions github-actions bot temporarily deployed to pr-5529-docs-poc-newinfobox April 26, 2024 15:57 Inactive
Signed-off-by: Dj Walker-Morgan <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-5529-docs-poc-newinfobox April 26, 2024 16:34 Inactive
(this ensures that scroll is restored when navigating back)
Copy link
Contributor

@josh-heyer josh-heyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I was able to simplify the code a bit, and fix that issue where navigating back to the top level didn't restore scroll position - that's probably been a bug forever, so nice to have it solved finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants