Skip to content

Small fix for edge case where planned or prepared have now rows in db #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

ainefairbrother
Copy link
Contributor

@ainefairbrother ainefairbrother commented Jun 18, 2025

Two small fixes:

  • Added in conditional logic for when planned or prepared status metadata db query yields no result - don't apply .pop, set variable to None and don't write JSON file, but do notify that this has occurred in the log file.
  • Prevent warning being thrown erroneously when planned_ids.pop() or prepared_ids.pop() evaluates to an empty set with length 0 - this was throwing a WARN that there were multiple unique IDs due to !=1

@ainefairbrother ainefairbrother requested a review from nakib103 June 18, 2025 08:29
@ainefairbrother ainefairbrother changed the title Very small fix to prevent incorrect warning Small fix for edge case where planned or prepared have now rows in db Jun 18, 2025
@nakib103 nakib103 merged commit dc846f5 into Ensembl:main Jun 19, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants