Make the sort options go through i18n. #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The strings used in the sort options for search now go through i18n.
Motivation and context
As has come up elsewhere, a Canadian fork for TeSS is striving to make an English/French bilingual instance. There are many places in the TeSS code base where strings in the view don't go through i18n. This PR just handles just the sort options for searching. (Note: I think it might be better to send these improvements in smaller atomic PRs rather than in one mega-PR.)
Screenshots
Looks the same as before.
Checklist
to license it to the TeSS codebase under the
BSD license.