Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIO0 and DIO1 optional and deep sleep for ESP device #184

Closed
wants to merge 10 commits into from

Conversation

sacua
Copy link
Contributor

@sacua sacua commented Mar 23, 2024

Similar to https://github.com/sandeepmistry/arduino-LoRa/tree/master, I've changed to code so that DIO0 and DIO1 can now be optional.

Moreover, similair to the closed issue #130, I've change some variable that were private to public, so those seetings can be explicitelly save on RTC RAM and surive deep sleep for ESP device. I've added an example for your consideration in that regards.

I've tested this code for Class A device, but not class C.

@sacua
Copy link
Contributor Author

sacua commented Mar 23, 2024

I would need to be in front of my computer to validate but all fail seems to be related to the added example specifically made for esp8266 device. This example is not mandatory but help to understand how to use deep sleep for this device with this library.

@sacua
Copy link
Contributor Author

sacua commented Mar 24, 2024

As I understand that the code is verified by github action in order to be sure that everything is compiling, I decided to remove the example and update README by adding a section deepsleep that are more related to ESP32 and ESP8266 for which in those device, all the memory is flush at deep sleep except the RTC memory.

Copy link
Contributor

@REGIOIGER REGIOIGER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use #if defined (ESP32) || (ESP8266) compilation directives for ESP MCs. An example of how to store the structure in RTC memory would be valuable.

Custom RX delay and windows can now be set. The
things stack use a Rx1 delay of 5 seconds.

Cleanup RFM_Set_Tx_Power, setTxPower and
setTxPower1
Copy link
Contributor Author

@sacua sacua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example for deep sleep with ESP device have been added. I've made also a few other modification in the code for your consideration. The most important one is the possibility to change the RX delay and windows. Under the thing stack, the RX1 delay is 5 seconds.

Copy link
Contributor Author

@sacua sacua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete comments

@sacua sacua mentioned this pull request Apr 25, 2024
@sabas1080 sabas1080 requested a review from wero1414 April 26, 2024 20:59
@sabas1080
Copy link
Member

#188 #189 #190

@sabas1080 sabas1080 closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants