Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SPI pins configurable #176

Closed

Conversation

ottonemo
Copy link

I wanted to be able to choose which pins the SPI uses for communication but this was not yet possible.
The default values for the pin assignment are still < 0 so the default values should apply and the change
should be backward compatible.

I also noted that there is a hard coded analogue read on pin 0 to get a random seed.
The ESP32-S2 for example has no ADC on pin 0 which will make it fail.
Is this already on the roadmap?

@sabas1080
Copy link
Member

@ottonemo Thanks for your contribution but it seems that pullrequest has not passed the unit tests, please review

Copy link
Member

@sabas1080 sabas1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the best way to do this would be to create instances so that the defined ports can function.

@sabas1080 sabas1080 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants