Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type hints support #72

Open
antonkulaga opened this issue Nov 2, 2022 · 1 comment
Open

type hints support #72

antonkulaga opened this issue Nov 2, 2022 · 1 comment

Comments

@antonkulaga
Copy link

It would be useful to have type-hints as it allows better reasoning about the code and avoiding some errors

@veghp
Copy link
Member

veghp commented Nov 2, 2022

Thanks for the feedback, I agree it may be useful with the size and complexity of some of the packages, but there are some counterarguments in our case: it's a non-trivial undertaking especially if we want to maintain style consistency across the EGF package ecosystem, with no function gain for the user. Therefore this is likely will not be implemented, but will keep open to the idea. Please note that these packages are used in very expensive lab operations, and in other non-EGF packages and companies, therefore we have to be very conservative with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants