Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to be compatible with numpy 2.1 #85

Merged

Conversation

godotgildor
Copy link

@godotgildor godotgildor commented Aug 26, 2024

With numpy >= 2.1, there is an error triggered in EnforceGCContent, indicating that calling "nonzero on 0d arrays" is not permitted.

This PR updates the code to be compatible with numpy >= 2.1 (and still works for older versions).

Related to this issue:
#83

Similar in spirit to #84 (didn't see that PR when I originally issued this one.)

@veghp veghp changed the base branch from master to dev August 29, 2024 10:29
@veghp veghp merged commit f200677 into Edinburgh-Genome-Foundry:dev Aug 29, 2024
@veghp
Copy link
Member

veghp commented Aug 29, 2024

Thank you! I'll have to make a few more tests and address some other issues, then I can make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants