Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): correct different B&W and colorlcd trainer slave UI behaviour #5067

Merged
merged 4 commits into from
May 30, 2024
Merged

fix(radio): correct different B&W and colorlcd trainer slave UI behaviour #5067

merged 4 commits into from
May 30, 2024

Conversation

pfeerick
Copy link
Member

Summary of changes:

  • on bw212, the "Slave" text was off-center due to double centering. had no effect on bw128
  • on colorlcd, master trainer settings were still visible when in master mode, whereas hidden on B&W

@pfeerick
Copy link
Member Author

@philmoz Would you mind prettifying the STR_SLAVE text alignment - i.e. vertical/horizontally centred as on bw?

@pfeerick pfeerick added this to the 2.11 milestone May 25, 2024
@pfeerick pfeerick added bug 🪲 Something isn't working house keeping 🧹 Cleanup of code and house keeping labels May 25, 2024
@philmoz
Copy link
Collaborator

philmoz commented May 25, 2024

Would you mind prettifying the STR_SLAVE text alignment - i.e. vertical/horizontally centred as on bw?

Done. Also made the text larger.

@pfeerick pfeerick changed the title fix(radio): trainer slave UI fixes fix(radio): inconsistent trainer UI behaviour between B&W and colorlcd May 30, 2024
@pfeerick pfeerick changed the title fix(radio): inconsistent trainer UI behaviour between B&W and colorlcd fix(radio): different trainer slave UI behaviour for B&W and color May 30, 2024
@pfeerick pfeerick changed the title fix(radio): different trainer slave UI behaviour for B&W and color fix(radio): correct different B&W and colorlcd trainer slave UI behaviour May 30, 2024
@pfeerick pfeerick merged commit 2952ee4 into main May 30, 2024
44 checks passed
@pfeerick pfeerick deleted the fix-trn-slave-ui branch May 30, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🪲 Something isn't working house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@pfeerick @philmoz