refactor(color): UI code cleanup, speed up loading of complex pages

[philmoz]

Round 2 of the UI code refactoring.

Summary of changes:

• Convert magic numbers to class constants and move layout constants to classes as well.
• Speed up Radio Setup and Radio Hardware page layout.
• Speed up flight modes and global variables pages (note: new layout for GV page with header at the top).
• Speed up text entry and number entry field creation when pages are created.
• Fix for Radio Hardware page not setting battery read state on exit.
• Use a dialog popup for renaming files in the SD manager instead of a full screen.

The Lvgl textarea object used by the text entry and number entry fields is slow to create and layout. To avoid excessive overhead on pages and popups with a lot of text entry fields, these classes have been changed significantly.
Users should not see any difference (I hope); but under the hood they are now created as simple buttons. When the button is activated a text / number entry field is created over the top of the button and the appropriate UI activated to allow editing. On exit the text / number entry field is destroyed.

[philmoz]

Removing the flex layout in the Choice button speeds up pages with many Choice fields.
Requires moving the icon to the left to avoid expensive calculations on the length of the text field.

Before:

After:

[pfeerick]

When I try to go into Model Settings -> Curves -> +/new curve -> CV1 the radio just freezes.

One minor detail - the button matrix sizing for Model Settings -> Other seems to be a bit small

• 

Otherwise, this looks fantastic... getting to the point I don't notice it being 🐌 "slow".

[philmoz]

Curve edit and center beeps should be fixed now.

[pfeerick]

One more minor one... Where it normally says "Loading" here the bottom part of the text is clipped.

One side effect of the

now created as simple buttons. When the button is activated a text / number entry field is created over the top of the button and the appropriate UI activated to allow editing.

seems to be that a long press on a "text' field can now oddly - where it will sometimes half-highlight it, and not actually activate/select it (with rotary encoder, touch seems fine)?

[philmoz]

One side effect of the

now created as simple buttons. When the button is activated a text / number entry field is created over the top of the button and the appropriate UI activated to allow editing.

seems to be that a long press on a "text' field can now oddly - where it will sometimes half-highlight it, and not actually activate/select it (with rotary encoder, touch seems fine)?

That probably needs the fixes in #5107 - will try it out.

[pfeerick]

That probably needs the fixes in #5107 - will try it out.

Just let me know which way you want to go with that one... I was thinking that since it relates to long press handling, so don't want to break that too much with any overlap from this PR...

[philmoz]

'Loading' message height fixed.
The button issue is fixed by 5107 - they can go in either order as they are mostly independent. A couple of minor fixes either way.

[pfeerick]

Thanks. Ok, lets keep them in order then... this one first, then 5107 soon.