feat: customisable switches generated sources

[3djc]

This add 3 sources (GR1 to GR3) on radio that have customisable switches as described in #4989

This PR is best when used in conjunction with #4994 (which prevents user misconfiguration)

This fixes #4989

@elecpower: I've done my best for companion support, but please check thoroughly.

[elecpower]

@3djc IMO this needs to be based on #4722.
@philmoz and I have already spent time keeping 4722 rebased (the sooner it is merged or closed the better).
I'll have a look at what you have done so far and provide feedback but not approve until priorities are resolved by someone on a higher pay grade.

[pfeerick]

Sounds good to me... had been ignoring it somewhat since it was still tagged as 'draft'. So looks like it will be #4722, #4994 and then #5016 (in order of age)?

[elecpower]

Tested Companion and T20 libsim.

1. create new model in Companion - pass
2. configure custom switches across 2 groups - pass
3. add inputs, mixes, logical switches and special functions referencing the 3 groups and sources either side in the lists - pass
4. save, close and reopen the models and settings - pass
5. check Companion encode and decode - pass
6. launch simulator - pass
7. check simulator decode - pass
8. make a small change to force the yaml to be written - pass
9. copy and zip the files into an etx file - pass
10. close the simulator - pass
11. close the models and settings - pass
12. open the simulator generated models and settings - pass
13. check the simulator encode and Companion decode - pass

For consistency with other sources and switches and to keep lists short, groups should only be available for selection in lists when they are configured.

The groups should optionally allow them to have user defined names assigned like all other sources and switches, and for the same reasons they have user defined names. I can imagine this would be the first enhancement request after the feature becomes available so why not do it as part of this implementation to save rework.

[elecpower]

Sounds good to me... had been ignoring it somewhat since it was still tagged as 'draft'. So looks like it will be #4722, #4994 and then #5016 (in order of age)?

Re Draft, I do not see any changes except for rebases from @philmoz so best to check with him him being ready for Review.

[elecpower]

@3djc 4722 WILL break this due to the index change from zero to one based

[3djc]

I'll review this when #4722 gets merged, but I agree, we need to changes merged sooner rather than later

[3djc]

Ready for test

[elecpower]

Still needs to have unused/not configured GRx suppressed to be consistent with other types

[3djc]

Still needs to have unused/not configured GRx suppressed to be consistent with other types

Radio side is ready to push, where should I look in companion code for cpn ?

[elecpower]

RawSource::isAvailable to show/hide in lists.
Ensure group config changes trigger the lists to be refreshed.

[3djc]

Will add companion side show/not show once #4994 has been merged, as some functions I need are in there. Anohow, thats more icing o n the cake and can be merge as such imho

[elecpower]

IMHO it does not get merged until it is a completed feature as this is how the two get out of sync.

[3djc]

@elecpower , could you please take care of : Ensure group config changes trigger the lists to be refreshed.

[3djc]

Thanks @elecpower , seems to work ok :) (obviously your change do, but I was referring here about the whole PR :))

[pfeerick]

This is working better than I could have hoped when the customisable switches were first introduced, and the need for a traditional 6POS needed.

Just one tiny detail... GR2 and GR3 don't actually appear to giving any output here? GR1 works, but GR2 and GR3 don't 😢 Unless I missed something in configuring this?

pr5016.yml.zip

Just a thought... can we get something for the GRx in the popup source lists also? Not an issue either way, as logical switches aren't there either, so maybe this is can be considered a switch also?

[3djc]

I believe I have fixed the computation issue (thanks to the just in time T15 merged that allowed me to work with debug (yeah !!)), but please test it thoroughly.

Not sure I understand your other point, maybe ping me on discord ?

[pfeerick]

I think that is probably topic for a followup PR... I was referring to this popup menu...

Would be nice to have shortcuts to the customisable switch groups and/or LS... but it also needs to not show trainer when trainer is not actually configured.

On colorlcd, probably needs to get added to the switches filter group also.

And I thought you'd like being able to rebase to include the T15 ;)

[pfeerick]

LGTM on T-Pro and T15 :)