Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve customisable switches with automatic "source " #4989

Closed
1 task done
3djc opened this issue May 11, 2024 · 7 comments · Fixed by #5016
Closed
1 task done

Improve customisable switches with automatic "source " #4989

3djc opened this issue May 11, 2024 · 7 comments · Fixed by #5016
Assignees
Labels
enhancement ✨ New feature or request

Comments

@3djc
Copy link
Collaborator

3djc commented May 11, 2024

Is there an existing issue for this feature request?

  • I have searched the existing issues

Is your feature request related to a problem?

Currently, customisable switches are only switches, and if you want say have it work like a 6POS, it does create a lot of work

Describe the solution you'd like

Creation of 3 sources (GR1 to GR3) that match the customisable switches groups
Those source will be managed by the system without user intervention.
They will range from -100 to 100 with as many steps as there are switches in the group. If 0 switches in group, then source value is set to 0

If you have model default, all customisable switches are in group 1 and "always on' not enable, you will have
GR1: -100 to 100 in 7 steps
GR2: always 0
GR3: always 0

If you have model default, all customisable switches are in group 1 and "always on' enabled, you will have
GR1: -100 to 100 in 6 steps
GR2: always 0
GR3: always 0

If you have 4 switches in group1 and 2 in group 2 and both groups "always on" disabled:
GR1: -100 to 100 in 5 steps (all off = -100, sw1 = -50, sw2 = 0 , sw3 = 50, sw4 = 100)
GR2 : -100 to 100 in 3 steps (both off = -100, sw5 = 0, sw6 = 100)
GR3: always 0

If you have 4 switches in group1 and 2 in group 2 and group 1 "always on" enabled:
GR1: -100 to 100 in 4 steps (sw1 = -100, sw2 = -33 , sw3 = 33, sw4 = 100)
GR2 : -100 to 100 in 3 steps (both off = -100, sw5 = 0, sw6 = 100)
GR3: always 0

Describe alternatives you've considered

Use SF like today

Additional context

No response

@3djc 3djc added the enhancement ✨ New feature or request label May 11, 2024
@philmoz
Copy link
Collaborator

philmoz commented May 11, 2024

Sounds good.

Although if the group is set to always on then you would get one less step as you can't turn off all the switches in the group.

@pfeerick
Copy link
Member

That's what I'm hoping will happen here... in using this I would want this to simply replace a 6POS properly, so only 6 positions, not 7! 🤣

@3djc
Copy link
Collaborator Author

3djc commented May 11, 2024

That's what I'm hoping will happen here... in using this I would want this to simply replace a 6POS properly, so only 6 positions, not 7! 🤣

yes, simply declare group1 always on, and remember also to set your start position either to remember or decide an initial position.

Clarified description.

@CapnBry
Copy link
Contributor

CapnBry commented Jun 11, 2024

You magnificent son of a bic. Just got the T15 and thought, man this functional switch groups 6POS is so amazing and so close to perfect but all I need is a GRPx source that behaves exactly like you've described. I was browsing the code here trying to figure out where it would need to go and was confused how it already seemed to exist, then the git blame lead me here.

A-mazing, everyone is going to be begging for more handsets with hardware that supports this.

@pfeerick
Copy link
Member

A-mazing, everyone is going to be begging for more handsets with hardware that supports this.

1000% agree... this was really the missing piece since customisation switches were first added... i.e. how to make them make them act like a traditional 6POS without a gazillion mixer lines, logical switches, etc, if you don't want the extra functionality offered. It will be disappointing if future radios designs that have a 6POS button implementation don't come with customisation switches as standard, now that this pain point is gone - and in point of fact is far superior to that since you could quite easily have two 3POS, three 2POS switches just by grouping them how you want them!

@3djc
Copy link
Collaborator Author

3djc commented Jun 12, 2024

You can even have two 4POS since groups don't have to be always on

@3djc
Copy link
Collaborator Author

3djc commented Jun 12, 2024

Next step is user controlled led color when using ws2812, but it is a UI chalenge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants