Disallow unsupported FIO assets

[Jon-edge]

This change doesn't cover all situations, but at least prevents new FIO actions from using unsupported assets.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1210745903503290

[swansontec]

This should move to fioConstants.ts, and should use the same logic of const fioAssets = infoServerData.rollup?.fioAssets ?? FIO_ASSET_MAP. That way it still works if the info server is down. The info server data is supposed to be supplemental to stuff baked in the app.

Indeed, the logic could just be added to tokenIdToFioCode, which would be edited to return | undefined. Then we know any place we might send and Edge currency to Fio-land it's actually something Fio supports.

If that's a big change, then just moving this to the right file would be enough for the merge.

[Jon-edge]

Yeah it was intentionally separated because moving to the existing fio<>asset utils had a lot of fallout

[cursor]

Bug: Inconsistent Token Validation Functions

The new validateFioAsset function is inconsistent with the existing tokenIdToFioCode function. validateFioAsset only checks fioAsset.tokenCodes?.[tokenId] for tokens, returning isValid: false if not explicitly mapped. However, tokenIdToFioCode includes a fallback to currencyConfig.allTokens[tokenId]?.currencyCode for tokens not in the special mapping. This makes validateFioAsset more restrictive, especially since the updated FIO_ASSET_MAP has fewer explicit tokenCodes. Consequently, validateFioAsset may reject tokens that tokenIdToFioCode can successfully convert, leading to inconsistent behavior (e.g., valid tokens being filtered out in the UI).

src/constants/FioConstants.ts#L186-L231

edge-react-gui/src/constants/FioConstants.ts

Lines 186 to 231 in 48ec0ad

	*/
	export const validateFioAsset = (
	currencyConfig: EdgeCurrencyConfig,
	tokenId: EdgeTokenId
	): FioValidationResult => {
	const fioAssets = infoServerData.rollup?.fioAssets ?? FIO_ASSET_MAP
	const { pluginId } = currencyConfig.currencyInfo
	// Check if this plugin is supported
	const fioAsset = fioAssets[pluginId]
	if (fioAsset == null) {
	return {
	isValid: false,
	error: `${currencyConfig.currencyInfo.displayName} is not supported by FIO Protocol`
	}
	}
	const fioChainCode = fioAsset.chainCode
	// For native assets (tokenId is null)
	if (tokenId == null) {
	return {
	isValid: true,
	fioChainCode,
	fioTokenCode: fioChainCode
	}
	}
	// For tokens, check if the token is in the whitelist
	const fioTokenCode = fioAsset.tokenCodes?.[tokenId]
	if (fioTokenCode == null) {
	const tokenInfo = currencyConfig.allTokens[tokenId]
	const tokenName =
	tokenInfo?.displayName ?? tokenInfo?.currencyCode ?? tokenId
	return {
	isValid: false,
	error: `${tokenName} is not supported by FIO Protocol`
	}
	}
	return {
	isValid: true,
	fioChainCode,
	fioTokenCode
	}
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎