This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update Facebook SDK to latest #1852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
facebook-login v12 introduces a transitive dependency via facebook-common on androidx.fragment 1.3.0 that breaks navigation in nested frames, as @nativescript/core and @nativescript/android expect 1.2.5 which doesn't cause the issue. Here is an alternate PR for 11.+: #1868 that still resolves the webview issue but doesn't have the fragment dep. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android version was pinned to v5 whereas Facebook recently requires a more recent version (latest major is v12) due to security considerations where the previously used webview is not allowed anymore and prevents Android users from using FB auth.