Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

[FEATURE] Edit button on manage links page #8996

Closed
wants to merge 4 commits into from

Conversation

harshu0026
Copy link

Closes #8824

Fixes Issue #8824

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-09-08 200700

Screenshot 2023-09-08 200559

Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are glad that you want to contribute but you cannot send Pull Request without getting the issue assigned to you since this issue is assigned to someone else, we can't accept your Pull Request. I would recommend you to read our contributing guidelines https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md.
Please close this Pull Request.

@harshu0026
Copy link
Author

Sure no worries

@harshu0026 harshu0026 closed this Sep 8, 2023
@eddiejaoude
Copy link
Member

Thanks @harshu0026 and @sital002 is correct 👍 but please comment on the issue as I don't think there has been any activity for 2 weeks on that issue, and from our contributing guide it can be re-assigned after 2 weeks with no activity - comment and the maintainers can take a look into the status #8824

@harshu0026
Copy link
Author

Sure I do

@harshu0026 harshu0026 changed the title [UPDATE] Edit button on manage links page [FEATURE] Edit button on manage links page Sep 30, 2023
@harshu0026 harshu0026 reopened this Sep 30, 2023
@github-actions github-actions bot added the issue linked Pull Request has issue linked label Sep 30, 2023
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. The button overlaps other features that you might not have setup in your local dev environment

Screenshot 2023-10-25 at 21 47 57

@eddiejaoude
Copy link
Member

No activity for over 2 weeks, I will close and unassign so it is not blocked

@eddiejaoude eddiejaoude closed this Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Edit button on manage links page looks out of place
3 participants