Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Edit button on manage links page looks out of place #8824

Open
Njong392 opened this issue Aug 28, 2023 · 28 comments · May be fixed by #9886 or #10227
Open

[FEATURE] Edit button on manage links page looks out of place #8824

Njong392 opened this issue Aug 28, 2023 · 28 comments · May be fixed by #9886 or #10227
Assignees
Labels
⭐ goal: addition undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@Njong392
Copy link
Contributor

Description

On the links page, we have the edit button over the button itself, and it's covering the icon such that it looks a little bit weird. Is there no way to shift the edit circle? Maybe put it at the end of the link button, or within it like the milestone page?

Screenshots

Screenshot (182)

Additional information

No response

@Njong392 Njong392 added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Aug 28, 2023
@github-actions
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
@SaraJaoude
Copy link
Member

Good suggestion, it should be kept the same as the Milestone page as the edit button was recently updated for similar reasons.

@SaraJaoude SaraJaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 3 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Aug 28, 2023
@github-actions github-actions bot unlocked this conversation Aug 28, 2023
@github-actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@mishra-nikhil0110
Copy link
Member

I can work on this issue.
Please assign this to me.

@SaraJaoude
Copy link
Member

I can work on this issue.
Please assign this to me.

@mishra-nikhil0110 I have assigned this to you

@umar-webdev
Copy link

Can I Work if @mishra-nikhil0110 is not working on it.

@SaraJaoude
Copy link
Member

Can I Work if @mishra-nikhil0110 is not working on it.

@umar-webdev please familiarise yourself with our Contributing Guide. This issue was only assigned to @mishra-nikhil0110 last week. Please allow for no activity for two weeks we mention in the Guide, before asking for this issue to be assigned to you.

@harshu0026
Copy link

Hey, I have already fixed this issue but as a guideline, I can't make a pull request so Please check if @mishra-nikhil0110 is working on this issue or not If not please assign this issue to me.
Thank you!

@sital002
Copy link
Member

@mishra-nikhil0110 Can you give an update on why is it taking so long?

@SaraJaoude
Copy link
Member

As there has been no activity for over two weeks I am unassigning this issue from @mishra-nikhil0110

@harshu0026
Copy link

Hey @SaraJaoude I wanna work on this issue please assign this to me

@SaraJaoude
Copy link
Member

Hey @SaraJaoude I wanna work on this issue please assign this to me

@harshu0026 I have assigned this to you.

@SaraJaoude SaraJaoude added the Hacktoberfest Good issues for Hacktoberfest participants label Oct 1, 2023
@harshu0026
Copy link

Hey @SaraJaoude I have Open a PR please Chcek
Thank you!

@SaraJaoude
Copy link
Member

Hey SaraJaoude I have Open a PR please Chcek
Thank you!

We got the notification - please do not chase in the issue as well. Please be respectful that maintainers are working through the PRs and we will get to yours in due course.

@TusharKumawat1
Copy link

TusharKumawat1 commented Oct 23, 2023

Given the lack of recent activity, I'd like to request that this issue be assigned to me. Additionally, I have a few questions I'd like to address.

@sital002
Copy link
Member

Given the lack of recent activity, I'd like to request that this issue be assigned to me. Additionally, I have a few questions I'd like to address.

@TusharKumawat1 We are glad that you want to work on the issue but @harshu0026 has already raised a PR and it is ready for review so you can look for another issue

@eddiejaoude
Copy link
Member

eddiejaoude commented Nov 6, 2023

There has been on activity for 2 weeks, so I have closed the PR. @TusharKumawat1 would you still like the issue?

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

@Theodoric-Graham
Copy link

Hello I would like to contribute to this issue. If there is no response from the others, please assign this to me. Thank you!

@GauravLokhande16
Copy link

Hello, If no one is working on this issue. please assign this to me. I want to contribute to this. Thank you.

@sital002
Copy link
Member

sital002 commented Dec 6, 2023

Assigning the issue to you @Gaurav1607

ℹ️ sital002 has some opened assigned issues: 🔧View assigned issues

@sandhyabaiju86
Copy link

Hello, I would like to contribute to this issue. If there is no response from the others, please assign this to me. Thank you!

@sital002
Copy link
Member

@sandhyabaiju86 We are glad that you want to contribute but there is already a open PR ready to be merged.
Please find another unassigned and status:ready for dev issue and familarize with our contributing guidelines

@SaraJaoude
Copy link
Member

I am unassigning due to the reasons mentioned here: #9956 (comment)

@hi-Kartik2004
Copy link
Contributor

hi-Kartik2004 commented Feb 8, 2024

Hi, I have made a PR which fixes this issue and also tried keeping the code changes clean and minimal, I have also addressed a common query raised in ( #9886 and #9956 ) in my PR #10227

@chetannada
Copy link
Contributor

Hi, I have made a PR which fixes this issue and also tried keeping the code changes clean and minimal, I have also addressed a common query raised in ( #9886 and #9956 ) in my PR #10227

Hi Kartik,
If this issue is assigned to you then you can start your work and raise PR. check more in CONTRIBUTING.md

@SaraJaoude
Copy link
Member

Hi, I have made a PR which fixes this issue and also tried keeping the code changes clean and minimal, I have also addressed a common query raised in ( #9886 and #9956 ) in my PR #10227

@hi-Kartik2004 as mentioned by another contributor please read through this project's Contributing Guide. We ask our contributors to only open PRs once the Issue has been assigned to them. On this occasion only I will assign this Issue to you, but in future please follow the project's requirements.

@hi-Kartik2004
Copy link
Contributor

hi-Kartik2004 commented Feb 15, 2024

Hi Kartik, If this issue is assigned to you then you can start your work and raise PR. check more in CONTRIBUTING.md

Hi Chetan,
I've raised a PR (#10227). If you could take some time out for a review, I would greatly appreciate it. Your insights will contribute to enhancing code reliability and instilling confidence for the maintainers.

I apologise for any confusion caused due to the un-assignment of the issue.

@hi-Kartik2004
Copy link
Contributor

@hi-Kartik2004 as mentioned by another contributor please read through this project's Contributing Guide. We ask our contributors to only open PRs once the Issue has been assigned to them. On this occasion only I will assign this Issue to you, but in future please follow the project's requirements.

Thank you for assigning the issue to me. Regrettably, I overlooked its initial assignment status and raised the PR hastily. I will ensure to address this aspect in the future, as I have in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment