[RND-704][RND-670] Update MetaEd and DS, begin/end dates optional on descriptors #341
Conversation
Meadowlark-js/packages/meadowlark-core/src/api-schema/ApiSchemaLoader.ts
Outdated
Show resolved
Hide resolved
andonyns
dismissed
their stale review
Waiting on confirmation from Stephen's comment
bradbanister
changed the title
There was a problem hiding this comment.
These are some big files. Which is fine at the moment. For Tanager, we'll probably want to compress the files. But we'll also need to think about the extension developer experience.
I tried to edit this file in VS code, removing all leading spaces. Wanted to see what difference that makes in the file size. VS Code completely froze when I tried to save it. Had to kill it with task manager. Notepad did better.
Result: file size from 4,2xy KB (wasn't looking closely) down to 2,501 KB.
There was a problem hiding this comment.
It could be trimmed down significantly. The current format has the JSON Schemas repeating three times for each resource because there are variations between insert, update and query parameters. The variations of update and query are small and can be tweaked at startup time or runtime. I pre-generated all of them in the interest of performance, but agree with the bloat. It makes it hard to inspect the file manually.
There was a problem hiding this comment.
As an aside, ODS/API's ApiModel.json runs around 4400KB these days...
No description provided.