Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RND-697] Refactor test to avoid race conditions on depending tests #334

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

andonyns
Copy link
Contributor

@andonyns andonyns commented Dec 21, 2023

Current behavior depends on a previous test before doing the next one, for example, to test the delete, it requires a previous it() to have run to set the element to delete, this causes a race condition since we cannot guarantee that the prerequisite will run first. This move that behavior as part of the before all hook

@andonyns andonyns changed the title Attempt to replicate issue [RND-697] Refactor test to avoid race conditions on depending tests Dec 21, 2023
@andonyns andonyns marked this pull request as ready for review December 22, 2023 15:32
@bradbanister bradbanister merged commit d5d5534 into main Dec 22, 2023
15 checks passed
@bradbanister bradbanister deleted the RND-697 branch December 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants