[RND-649] Add lerna version update process into GitHub Action #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andonyns
commented
Nov 14, 2023
| "npmClient": "npm", | ||
| "useWorkspaces": true, | ||
| "command": { |
There was a problem hiding this comment.
This could potentially allow users to create tags with lerna from branches, but this is currently possible from git tags also
andonyns
commented
Nov 14, 2023
| @@ -3,12 +3,7 @@ | |||
| "packages": [ | |||
| "packages/*" | |||
| ], | |||
| "version": "v0.3.0-pre-35", | |||
| "version": "0.4.0-pre.0", | |||
There was a problem hiding this comment.
This update had to be done manually for the first version, this will be done automatically in future changes
andonyns
commented
Nov 14, 2023
| - name: Get changes | ||
| id: changes | ||
| run: | | ||
| suggested=v$(cat lerna.json | jq -r .version) |
There was a problem hiding this comment.
To check whether or not we need to add a new commit for the new version, we compare the value in lerna.json against the latest tag available, if it's different, we assume that a change has already be done as part of this PR.
warning this means that manually updating the lerna.json version (not recommended) will cause the update not to run
| @@ -12,6 +12,10 @@ on: | |||
| - ".github/**" | |||
| workflow_dispatch: | |||
|
|
|||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |||
| cancel-in-progress: true | |||
stephenfuqua
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use lerna update process to apply changes into packages and commit changes into code.
Description
To see the changes in place, see https://github.com/andonyns/Meadowlark
Main branch has write protection so all changes are done via PR.
See andonyns#18 as a demo of a PR ready to be merged and tag has not been created