[RND-651] Ability to loosely allow overposted material for parity #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleiva-gap
force-pushed
the
RND-651-IntegrationTests
branch
from
094057a to
c798e2c
Compare
Add integration test for Get, Update and Upsert
Move initializeAjv to initializeAjv after clear the cache when tests are running
Add schema validator to have a cache for body and a separate cache for query parameters. Add conditions to avoid using ALLOW_OVERPOSTING if we are validating a query parameter schema. Update unit and integration tests.
Add integration test for Get, Update and Upsert
Add schema validator to have a cache for body and a separate cache for query parameters. Add conditions to avoid using ALLOW_OVERPOSTING if we are validating a query parameter schema. Update unit and integration tests.
…xchange-OSS/Meadowlark into RND-651-IntegrationTests
Enable test. Fix test to match RND-651 changes
jleiva-gap
changed the title
| const removeAdditional = false; // TODO: replace on merge with RND-651 | ||
| function initializeAjv(isQueryParameterValidator: boolean): Ajv { | ||
| // A query parameter validator cannot have additional properties | ||
| const removeAdditional = isQueryParameterValidator ? false : getBooleanFromEnvironment('ALLOW_OVERPOSTING', false); |
There was a problem hiding this comment.
Interestingly, the ODS/API does not reject spurious query string values. However, I agree with the approach here in Meadowlark. We should let people know that their query string was invalid.
stephenfuqua
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Overposting for resource.
Query parameter don't allow overposting.
Add unit and integration test.
Description
Types of changes
Checklist