Skip to content

Commit

Permalink
[RND-579] Update docker/Dockerfile (#262)
Browse files Browse the repository at this point in the history
* [RND-579] Update docker/Dockerfile

Add antlr4 url from azure artifacts instead of myget.
Move ARG.
Add ML_VERSION to npm install

* Update Dockerfile

Add double quote

* Update Dockerfile

Update comment
  • Loading branch information
jleiva-gap authored Jun 27, 2023
1 parent 8c9fb7d commit bb02c37
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

# This file builds a Meadowlark Ed-Fi API container from npm packages on Azure
# Artifacts
ARG ML_VERSION=latest
FROM node:16.17.0-bullseye-slim@sha256:fa84c820c0a1106e170137241a66583f80c899d9b4483e4d2d8a1a9e413c2978 as base
ARG ML_VERSION=latest
RUN apt-get update && \
apt-get upgrade -y && \
# dumb-init is useful for running node properly (not as PID 1)
Expand All @@ -22,11 +22,9 @@ WORKDIR /app
# Load all packages into Docker
COPY .npmrc /app

# Install the Meadowlark Fastify service TEMPORARY: install Ed-Fi custom antlr4
# from MyGet, because it cannot be deployed through Azure Artifacts due to lack
# of scope.
RUN npm i https://www.myget.org/F/ed-fi/npm/antlr4/-/4.6.1-patched.0.tgz && \
npm i @edfi/meadowlark-fastify && \
# Install the Meadowlark Fastify service
RUN npm i https://pkgs.dev.azure.com/ed-fi-alliance/Ed-Fi-Alliance-OSS/_packaging/EdFi/npm/registry/@edfi/antlr4/-/antlr4-4.6.1.tgz && \
npm i @edfi/meadowlark-fastify@"${ML_VERSION}" && \
chown -R node:node /app

EXPOSE 3000
Expand Down

0 comments on commit bb02c37

Please sign in to comment.