Update QueryStringValidatorForOverposting.test.ts

Enable test.
Fix test to match RND-651 changes

Meadowlark-js/packages/meadowlark-core/test/validation/QueryStringValidatorForOverposting.test.ts

@@ -41,27 +41,7 @@ function createResourceSchema(): ResourceSchema {
   };
 }
 
-describe('given query parameters have no properties', () => {
-  it('should not return an error', () => {
-    const queryParameters = {};
-
-    const validationResult = validateQueryParametersAgainstSchema(createModel(), queryParameters);
-
-    expect(validationResult).toHaveLength(0);
-  });
-});
-
-describe('given query parameters have a valid property', () => {
-  it('should not return an error', () => {
-    const queryParameters = { uniqueId: 'a' };
-
-    const validationResult = validateQueryParametersAgainstSchema(createModel(), queryParameters);
-
-    expect(validationResult).toHaveLength(0);
-  });
-});
-
-describe('given query parameters with allow overposting is false have two extraneous properties and a valid one', () => {
+describe('given query parameters with allow overposting is false have two invalid properties and a valid one', () => {
   let validationResult: string[];
 
   beforeAll(() => {
@@ -85,15 +65,15 @@ describe('given query parameters with allow overposting is false have two extran
   });
 
   it('should contain property `one`', () => {
-    expect(validationResult).toContain("Student does not include property 'one'");
+    expect(validationResult).toContain(" does not include property 'one'");
   });
 
   it('should contain property `two`', () => {
-    expect(validationResult).toContain("Student does not include property 'two'");
+    expect(validationResult).toContain(" does not include property 'two'");
   });
 });
 
-describe.skip('given query parameters with allow overposting is true have two extraneous properties and a valid one', () => {
+describe('given query parameters with allow overposting is true have two extraneous properties and a valid one', () => {
   let validationResult: string[];
 
   beforeAll(() => {
@@ -116,11 +96,11 @@ describe.skip('given query parameters with allow overposting is true have two ex
   });
 
   it('should contain property `one`', () => {
-    expect(validationResult).toContain("Student does not include property 'one'");
+    expect(validationResult).toContain(" does not include property 'one'");
   });
 
   it('should contain property `two`', () => {
-    expect(validationResult).toContain("Student does not include property 'two'");
+    expect(validationResult).toContain(" does not include property 'two'");
   });
 });
 
@@ -282,7 +262,7 @@ describe('given a bad decimal query parameter value', () => {
   });
 });
 
-describe.skip('given body insert with allow overposting is false have two invalid properties and a valid one', () => {
+describe('given body insert with allow overposting is false have two invalid properties and a valid one', () => {
   let validationResult: ValidationFailure | null;
 
   beforeAll(() => {
@@ -301,13 +281,20 @@ describe.skip('given body insert with allow overposting is false have two invali
     jest.restoreAllMocks();
   });
 
-  it('should have two errors', () => {
-    expect(validationResult).toHaveLength(2);
+  it('should have three errors', () => {
+    expect(validationResult?.error).toHaveLength(3);
   });
 
   it('should return validation errors', () => {
-    expect(validationResult).toMatchInlineSnapshot(`
+    expect(validationResult?.error).toMatchInlineSnapshot(`
     [
+      {
+        "context": {
+          "errorType": "additionalProperties",
+        },
+        "message": "'uniqueId' property is not expected to be here",
+        "path": "{requestBody}",
+      },
       {
         "context": {
           "errorType": "additionalProperties",
@@ -327,7 +314,7 @@ describe.skip('given body insert with allow overposting is false have two invali
   });
 });
 
-describe.skip('given body update with allow overposting is false have two invalid properties and a valid one', () => {
+describe('given body update with allow overposting is false have two invalid properties and a valid one', () => {
   let validationResult: ValidationFailure | null;
 
   beforeAll(() => {
@@ -346,13 +333,20 @@ describe.skip('given body update with allow overposting is false have two invali
     jest.restoreAllMocks();
   });
 
-  it('should have two errors', () => {
-    expect(validationResult).toHaveLength(2);
+  it('should have three errors', () => {
+    expect(validationResult?.error).toHaveLength(3);
   });
 
   it('should return validation errors', () => {
-    expect(validationResult).toMatchInlineSnapshot(`
+    expect(validationResult?.error).toMatchInlineSnapshot(`
     [
+      {
+        "context": {
+          "errorType": "additionalProperties",
+        },
+        "message": "'uniqueId' property is not expected to be here",
+        "path": "{requestBody}",
+      },
       {
         "context": {
           "errorType": "additionalProperties",
@@ -372,7 +366,7 @@ describe.skip('given body update with allow overposting is false have two invali
   });
 });
 
-describe.skip('given body insert with allow overposting is true have two invalid properties and a valid one', () => {
+describe('given body insert with allow overposting is true have two invalid properties and a valid one', () => {
   let validationResult: ValidationFailure | null;
 
   beforeAll(() => {
@@ -396,7 +390,7 @@ describe.skip('given body insert with allow overposting is true have two invalid
   });
 });
 
-describe.skip('given body update with allow overposting is true have two invalid properties and a valid one', () => {
+describe('given body update with allow overposting is true have two invalid properties and a valid one', () => {
   let validationResult: ValidationFailure | null;
 
   beforeAll(() => {