[EPPETA-19] Inject the base URL into the react application #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add env file to set the API base path
stephenfuqua
reviewed
Jan 3, 2024
| // TODO: replace hard-coded with some sort of runtime setting | ||
| // Will be fixed in EPPETA-19. | ||
| const BaseUrl = "https://localhost:7065"; | ||
| const BaseUrl = process.env.REACT_APP_EPPETA_API_BASE_PATH; |
There was a problem hiding this comment.
@jleiva-gap does this really work? I thought FetchHelpers was a client-side component, not a server-side component. But I may have misunderstood.
If it is serverside, then does this mean that one must run the application using the npm start function? That's probably acceptable inside a Docker container, but might be hard to do in a real installation, since it requires NodeJs.
Ideally in a real installation, the end-user would have a choice of webservers to run, without needing NodeJs. For example, just copy the html, compiled js files, css, and images into IIS or Apache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add env file to set the API base path