Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODS-5418] Remove DescriptorIds from descriptor resource payloads #868

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

simpat-adam
Copy link
Contributor

No description provided.

… Model.Definitions and implemented the PriorDescriptorIdRemover transformation to remove the unwanted PriorDescriptorId property from the Descriptor entity.
…gic for identifying when a property should be ignored from the JSON (and related API metadata).

Incorporated use of the JsonIgnore property in the Resources.mustache template to generate a JsonIgnore attribute in lieu of a Displayname attribute on resource properties used for JSON serialization.

Incorporated use of the JsonIgnore property into the resource extension method NonReferencedProperties which is used by the OpenApiMetadataDefinitionsFactory class to produce property-level Open API metadata.
…gnored properties (concrete descriptor ids).
…concrete DescriptorId has been removed from the API JSON model.
…h implicit extensions where there is no entity attached to the resource.
@gmcelhanon gmcelhanon marked this pull request as ready for review November 8, 2023 07:04
@simpat-jesus simpat-jesus merged commit 9f01dce into main Nov 9, 2023
16 checks passed
@simpat-jesus simpat-jesus deleted the ODS-5418 branch November 9, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants