Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODS-6065] Disallow null Application in ApplicationEducationOrganization #864

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

stephenfuqua
Copy link
Contributor

No description provided.

@stephenfuqua stephenfuqua requested a review from vimayya October 28, 2023 00:58
@stephenfuqua
Copy link
Contributor Author

I have no idea what to do about the build failure, @vimayya .

@simpat-adam
Copy link
Contributor

@stephenfuqua this needs a rebase. Also I think you need to update the Edfi.Admin.DataAccess package

@stephenfuqua
Copy link
Contributor Author

@stephenfuqua this needs a rebase. Also I think you need to update the Edfi.Admin.DataAccess package

The number of times I've had to rebase 😆 .

Not sure what you're looking for with the package update. I am a bit rusty on this team's protocols, not having done more than sporadic tickets in this project over the past three years.

@simpat-adam
Copy link
Contributor

@stephenfuqua this needs a rebase. Also I think you need to update the Edfi.Admin.DataAccess package

The number of times I've had to rebase 😆 .

Not sure what you're looking for with the package update. I am a bit rusty on this team's protocols, not having done more than sporadic tickets in this project over the past three years.

I published the nuget package from your branch: https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-ODS/actions/runs/6813557500/job/18528425165 you just need to update the package references for Edfi.Suite3.Admin.DataAccess to 7.1.15

@simpat-adam simpat-adam merged commit 1fb9091 into main Nov 9, 2023
14 checks passed
@simpat-adam simpat-adam deleted the ODS-6065 branch November 9, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants