[ODS-6058] Enforcement of uniqueness in extension collections #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpat-adam
approved these changes
Oct 20, 2023
…ension collections. Finalize support for "No Duplicate Members" validation as a resource validation. * Moved extension validation up to resource Extensions member (to allow for application of NoDuplicateMembers attribute to the generated Extension resources classes). * Revert previous change to ValidateAggregateExtensionsAttribute adding NoDuplicateMembers attribute and validation (this is too late in the process for extension updates to detect duplicates) * Convert other validation attributes to convert CompositeValidationResult to a standard ValidationResult when complete (allowing for validation results to be reported into model state for resource-level validations as well as existing entity-level validation logic). * Expand test coverage for all duplicate member scenarios (Create/Update x Standard/Extension collections)
Fixed unit test.
simpat-adam
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.