Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODS-6527] Optimize cached method invocation signature computations to eliminate use of SOH (small object heap) #1162

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

gmcelhanon
Copy link
Contributor

No description provided.

@axelmarquezh axelmarquezh marked this pull request as ready for review October 15, 2024 20:10
Copy link
Contributor

@axelmarquezh axelmarquezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substantial improvements both in execution time and allocations:

image

using Standart.Hash.xxHash;

[TestFixture]
public class XxHash3CodeTests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: add test coverage for null, ulong, long, byte[], short, and Resource types.

@axelmarquezh axelmarquezh merged commit f404d81 into main Oct 16, 2024
16 checks passed
@axelmarquezh axelmarquezh deleted the ODS-6527 branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants