Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODS-6332] NHibernate query issues relating to GeneralStudentProgramAssociation #1024

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

axelmarquezh
Copy link
Contributor

@axelmarquezh axelmarquezh commented Apr 15, 2024

I cherry picked PR 475 which fixes the NHibernate issue.
I also had to cherry pick PR 453 which includes fixes that let us execute the integration tests targeting PostgreSQL.

* Update to reference latest nhibernate

* POC Fix hashcode generatiion

* Improve hash functions

* Fix approval tests

* Fix SpecFlow test

* Use System.HashCode to build hash codes

* Fix CodeGen approval tests

* Ignore casing while generating hash codes

* Fix CodeGen approval tests

Co-authored-by: Ben Tillman <[email protected]>
Comment on lines -33 to -36
- name: Setup .NET
uses: actions/setup-dotnet@607fce577a46308457984d59e4954e075820f10a # v3.0.3
with:
dotnet-version: 3.1.x
Copy link
Contributor Author

@axelmarquezh axelmarquezh Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this step because we need .net sdk >= v6 which comes pre-installed with the base image.

AxelMarquez and others added 2 commits April 16, 2024 12:26
* Fix admin and security database initializers

* Add Lazy to the security repository

* Fix unit tests

* Update reference to DataAccess admin & security

* Fix Postman tests

* Update reference to DataAccess admin & security
@axelmarquezh axelmarquezh marked this pull request as ready for review April 16, 2024 22:51
@simpat-jesus simpat-jesus merged commit 283df94 into main-5x Apr 18, 2024
13 checks passed
@simpat-jesus simpat-jesus deleted the ODS-6332 branch April 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants