[ODS-6540] Fix TreatErrorsAsWarning typo (6x) (#1174)

Ed-Fi-Alliance-OSS · Oct 30, 2024 · 8b0f978 · 8b0f978
1 parent 50a8c46
commit 8b0f978
Show file tree

Hide file tree

Showing 22 changed files with 31 additions and 34 deletions.
diff --git a/Application/EdFi.Ods.Api/EdFi.Ods.Api.csproj b/Application/EdFi.Ods.Api/EdFi.Ods.Api.csproj
@@ -7,7 +7,7 @@
     <AssemblyVersion>99.99.99.00</AssemblyVersion>
     <RootNamespace>EdFi.Ods.Api</RootNamespace>
     <Copyright>Copyright © 2019 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <PackageProjectUrl>https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-ODS</PackageProjectUrl>
@@ -29,14 +29,13 @@
     <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.22.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Log4Net.AspNetCore" Version="8.0.0" />
     <PackageReference Include="Autofac.Extensions.DependencyInjection" Version="9.0.0" />
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="Npgsql" Version="8.0.3" />
     <PackageReference Include="Polly" Version="8.3.0" />
     <PackageReference Include="Quartz.AspNetCore" Version="3.8.0" />
     <PackageReference Include="Sandwych.QuickGraph.Core" Version="1.0.0" />
     <PackageReference Include="Standart.Hash.xxHash" Version="4.0.5" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.1" />
-    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.1" />
     <PackageReference Include="Microsoft.Extensions.FileProviders.Embedded" Version="8.0.1" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />

diff --git a/Application/EdFi.Ods.Common/EdFi.Ods.Common.csproj b/Application/EdFi.Ods.Common/EdFi.Ods.Common.csproj
@@ -21,7 +21,7 @@
     <PackageReference Include="FluentValidation" Version="11.9.0" />
     <PackageReference Include="log4net" Version="2.0.15" />
     <PackageReference Include="Microsoft.Data.SqlClient" Version="5.1.4" />
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="Npgsql" Version="8.0.3" />
     <PackageReference Include="Quartz" Version="3.8.0" />
     <PackageReference Include="Sandwych.QuickGraph.Core" Version="1.0.0" />

diff --git a/...tion/EdFi.Ods.Repositories.NHibernate.Tests/EdFi.Ods.Repositories.NHibernate.Tests.csproj b/...tion/EdFi.Ods.Repositories.NHibernate.Tests/EdFi.Ods.Repositories.NHibernate.Tests.csproj
@@ -4,7 +4,7 @@
     <AssemlbyName>EdFi.Ods.Repositories.NHibernate.Tests</AssemlbyName>
     <RootNamespace>EdFi.Ods.Repositories.NHibernate.Tests</RootNamespace>
     <Copyright>Copyright © 2019 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
@@ -22,7 +22,7 @@
     <PackageReference Include="FakeItEasy" Version="8.1.0" />
     <PackageReference Include="log4net" Version="2.0.15" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="NUnit" Version="4.0.1" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0">
       <PrivateAssets>all</PrivateAssets>

diff --git a/Application/EdFi.Ods.Standard/EdFi.Ods.Standard.csproj b/Application/EdFi.Ods.Standard/EdFi.Ods.Standard.csproj
@@ -16,7 +16,7 @@
     <DebugSymbols>true</DebugSymbols>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
   </ItemGroup>
   <ItemGroup>

diff --git a/Application/EdFi.Ods.Tests.TestExtension/EdFi.Ods.Tests.TestExtension.csproj b/Application/EdFi.Ods.Tests.TestExtension/EdFi.Ods.Tests.TestExtension.csproj
@@ -4,7 +4,7 @@
     <AssemblyName>EdFi.Ods.Tests.FakeExtension</AssemblyName>
     <RootNamespace>EdFi.Ods.Tests.FakeExtension</RootNamespace>
     <Copyright>Copyright © 2019 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
   </PropertyGroup>

diff --git a/Application/EdFi.Ods.Tests/EdFi.Ods.Common/Security/ApiClientAuthenticatorTests.cs b/Application/EdFi.Ods.Tests/EdFi.Ods.Common/Security/ApiClientAuthenticatorTests.cs
@@ -100,7 +100,6 @@ public void Should_return_null_identity()
 
         public class When_trying_to_authenticate_using_valid_key_and_invalid_secret : TestFixtureBase
         {
-            private ApiClientIdentity _apiClientIdentity;
             private ApiClientAuthenticator.AuthenticationResult _actualResult;
             private IApiClientAuthenticator _apiClientAuthenticator;
 
@@ -130,12 +129,6 @@ public void Should_return_false()
             {
                 _actualResult.IsAuthenticated.ShouldBeFalse();
             }
-
-            [Test]
-            public void Should_return_null_identity()
-            {
-                _apiClientIdentity.ShouldBeNull();
-            }
         }
     }
 }
diff --git a/Application/EdFi.Ods.Tests/EdFi.Ods.Tests.csproj b/Application/EdFi.Ods.Tests/EdFi.Ods.Tests.csproj
@@ -4,7 +4,7 @@
     <AssemblyName>EdFi.Ods.Tests</AssemblyName>
     <RootNamespace>EdFi.Ods.Tests</RootNamespace>
     <Copyright>Copyright © 2019 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
@@ -18,7 +18,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="EdFi.Suite3.Admin.DataAccess" Version="6.2.403" />
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="Autofac.Extras.FakeItEasy" Version="7.0.0" />
     <PackageReference Include="AutoMapper" Version="13.0.1" />
     <PackageReference Include="CompareNETObjects" Version="4.83.0" />

diff --git a/Application/Test.Common/OneTimeGlobalDatabaseSetupBase.cs b/Application/Test.Common/OneTimeGlobalDatabaseSetupBase.cs
@@ -29,7 +29,7 @@ public abstract class OneTimeGlobalDatabaseSetupBase
         private IDatabaseHelper _databaseHelper;
 
         [OneTimeSetUp]
-        public virtual async Task OneTimeSetUpAsync()
+        public virtual Task OneTimeSetUpAsync()
         {
             Configuration = new ConfigurationBuilder()
                 .SetBasePath(TestContext.CurrentContext.TestDirectory)
@@ -158,12 +158,16 @@ public virtual async Task OneTimeSetUpAsync()
 
             _dbCopyConnectionString = connectionStringBuilder.ConnectionString;
             Configuration.GetSection("ConnectionStrings").GetSection("EdFi_Ods").Value = _dbCopyConnectionString;
+
+            return Task.CompletedTask;
         }
 
         [OneTimeTearDown]
-        public virtual async Task OneTimeTearDownAsync()
+        public virtual Task OneTimeTearDownAsync()
         {
             _databaseHelper.DropMatchingDatabases(DatabaseCopyPrefix + "%");
+
+            return Task.CompletedTask;
         }
 
         public IDbConnection BuildOdsConnection(string token = null) => BuildConnection(GetConnectionString(token));

diff --git a/Application/Test.Common/Test.Common.csproj b/Application/Test.Common/Test.Common.csproj
@@ -4,7 +4,7 @@
     <AssemblyName>Test.Common</AssemblyName>
     <RootNamespace>Test.Common</RootNamespace>
     <Copyright>Copyright © 2019 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
   </PropertyGroup>

diff --git a/Utilities/GenerateSecurityGraphs/GenerateSecurityGraphs/GenerateSecurityGraphs.csproj b/Utilities/GenerateSecurityGraphs/GenerateSecurityGraphs/GenerateSecurityGraphs.csproj
@@ -3,7 +3,7 @@
     <OutputType>Exe</OutputType>
     <TargetFramework>net8.0</TargetFramework>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
   </PropertyGroup>
   <ItemGroup>

diff --git a/tests/EdFi.Admin.DataAccess.IntegrationTests/EdFi.Admin.DataAccess.IntegrationTests.csproj b/tests/EdFi.Admin.DataAccess.IntegrationTests/EdFi.Admin.DataAccess.IntegrationTests.csproj
@@ -9,7 +9,7 @@
     <Assembly>EdFi.Admin.DataAccess.IntegrationTests</Assembly>
     <RootNameSpace>EdFi.Admin.DataAccess.IntegrationTests</RootNameSpace>
     <Copyright>Copyright © 2019, Ed-Fi Alliance and contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>

diff --git a/tests/EdFi.Admin.DataAccess.UnitTests/EdFi.Admin.DataAccess.UnitTests.csproj b/tests/EdFi.Admin.DataAccess.UnitTests/EdFi.Admin.DataAccess.UnitTests.csproj
@@ -4,7 +4,7 @@
     <AssemblyName>EdFi.Admin.DataAccess.UnitTests</AssemblyName>
     <RootNamespace>EdFi.Admin.DataAccess.UnitTests</RootNamespace>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.Ods.Api.IntegrationTests/EdFi.Ods.Api.IntegrationTests.csproj b/tests/EdFi.Ods.Api.IntegrationTests/EdFi.Ods.Api.IntegrationTests.csproj
@@ -4,7 +4,7 @@
     <AssemblyName>EdFi.Ods.Api.IntegrationTests</AssemblyName>
     <RootNamespace>EdFi.Ods.Api.IntegrationTests</RootNamespace>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.Ods.Features.UnitTests/EdFi.Ods.Features.UnitTests.csproj b/tests/EdFi.Ods.Features.UnitTests/EdFi.Ods.Features.UnitTests.csproj
@@ -4,6 +4,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="FakeItEasy" Version="8.1.0" />

diff --git a/...Ods.Features.UnitTests/OpenApiMetadataDefinitionsFactoryProfileNamingStrategyUnitTests.cs b/...Ods.Features.UnitTests/OpenApiMetadataDefinitionsFactoryProfileNamingStrategyUnitTests.cs
@@ -86,7 +86,7 @@ private string GetActualResult(string schema, string resourceName, string operat
             var mockOpenApiMetadataResourceContext = A.Fake<IOpenApiMetadataResourceContext>();
 
             A.CallTo(mockOpenApiMetadataResourceContext).Where(a => a.Method.Name.Equals("get_ContextualResource"))
-              .WithReturnType<Resource>()
+              .WithReturnType<Resource?>()
               .Returns(null);
 
 

diff --git a/tests/EdFi.Ods.WebApi.CompositeSpecFlowTests/EdFi.Ods.WebApi.CompositeSpecFlowTests.csproj b/tests/EdFi.Ods.WebApi.CompositeSpecFlowTests/EdFi.Ods.WebApi.CompositeSpecFlowTests.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <RootNamespace>EdFi.Ods.WebApi.CompositeSpecFlowTests</RootNamespace>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
@@ -23,7 +23,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="EdFi.Suite3.Admin.DataAccess" Version="6.2.403" />
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="ApprovalTests" Version="6.0.0" />
     <PackageReference Include="Autofac.Extensions.DependencyInjection" Version="9.0.0" />
     <PackageReference Include="Dapper" Version="2.1.28" />

diff --git a/tests/EdFi.Ods.WebApi.IntegrationTests/EdFi.Ods.WebApi.IntegrationTests.csproj b/tests/EdFi.Ods.WebApi.IntegrationTests/EdFi.Ods.WebApi.IntegrationTests.csproj
@@ -4,15 +4,15 @@
     <AssemblyName>EdFi.Ods.WebApi.IntegrationTests</AssemblyName>
     <RootNamespace>EdFi.Ods.WebApi.IntegrationTests</RootNamespace>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
     <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="EdFi.Suite3.Admin.DataAccess" Version="6.2.403" />
-    <PackageReference Include="NHibernate" Version="5.5.0" />
+    <PackageReference Include="NHibernate" Version="5.5.2" />
     <PackageReference Include="ApprovalTests" Version="6.0.0" />
     <PackageReference Include="ApprovalUtilities" Version="6.0.0" />
     <PackageReference Include="Autofac.Extensions.DependencyInjection" Version="9.0.0" />

diff --git a/...dFi.Security.DataAccess.IntegrationTests/EdFi.Security.DataAccess.IntegrationTests.csproj b/...dFi.Security.DataAccess.IntegrationTests/EdFi.Security.DataAccess.IntegrationTests.csproj
@@ -6,7 +6,7 @@
     <Assembly>EdFi.Security.DataAccess.IntegrationTests</Assembly>
     <RootNameSpace>EdFi.Security.DataAccess.IntegrationTests</RootNameSpace>
     <Copyright>Copyright © 2024, Ed-Fi Alliance and contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>

diff --git a/tests/EdFi.Security.DataAccess.IntegrationTests/Repositories/MSSQL/SecurityRepoTests.cs b/tests/EdFi.Security.DataAccess.IntegrationTests/Repositories/MSSQL/SecurityRepoTests.cs
@@ -100,7 +100,7 @@ public void Should_not_get_action_by_name()
         public class When_getting_claimsResources : SecurityRepoTests
         {
             [SetUp]
-            public void Setup()
+            public new void Setup()
             {
                 string resourceName = "ResourceNameTest" + Guid.NewGuid().ToString("N");
 

diff --git a/tests/EdFi.Security.DataAccess.IntegrationTests/Repositories/PostgreSQL/SecurityRepoTests.cs b/tests/EdFi.Security.DataAccess.IntegrationTests/Repositories/PostgreSQL/SecurityRepoTests.cs
@@ -105,7 +105,7 @@ public void Should_not_get_action_by_name()
         public class When_getting_claimsResources : SecurityRepoTests
         {
             [SetUp]
-            public void Setup()
+            public new void Setup()
             {
                 string resourceName = "ResourceNameTest" + Guid.NewGuid().ToString("N");
 

diff --git a/tests/EdFi.Security.DataAccess.UnitTests/EdFi.Security.DataAccess.UnitTests.csproj b/tests/EdFi.Security.DataAccess.UnitTests/EdFi.Security.DataAccess.UnitTests.csproj
@@ -4,7 +4,7 @@
     <AssemblyName>EdFi.Security.DataAccess.UnitTests</AssemblyName>
     <RootNamespace>EdFi.Security.DataAccess.UnitTests</RootNamespace>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsTestProject>true</IsTestProject>

diff --git a/tests/EdFi.TestFixture/EdFi.TestFixture.csproj b/tests/EdFi.TestFixture/EdFi.TestFixture.csproj
@@ -3,7 +3,7 @@
     <TargetFramework>net8.0</TargetFramework>
     <Configurations>Debug;Release</Configurations>
     <Copyright>Copyright © 2020 Ed-Fi Alliance, LLC and Contributors</Copyright>
-    <TreatErrorsAsWarning>true</TreatErrorsAsWarning>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <RestorePackages>true</RestorePackages>
     <OutputType>Library</OutputType>
     <IsPackable>false</IsPackable>