[ODS-6577] Verify dependent workflows are success or not- Step Added #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semalaiappan
changed the title
axelmarquezh
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Additionally, please make the next changes to Publish to Docker Hub and Docker Test so that they don't execute 3 times every time we merge to main:
- Remove any
github.event.workflow_run.conclusion == 'success'checks - Add a call to
ahmadnassri/action-workflow-run-waitin a similar way we do in this workflow
| @@ -41,7 +42,7 @@ jobs: | |||
| build: | |||
|
|
|||
| runs-on: ubuntu-24.04 | |||
| if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }} | |||
| if: ${{ github.event_name == 'workflow_dispatch' }} | |||
There was a problem hiding this comment.
With this change, it will no longer be executed on merges to main; it will only be executed on manual dispatches.
This if should be removed altogether.
Comment on lines
60
to
108
| run: | | ||
| $workflowNames = @("InitDev, Smoke Tests.yml", "InitDev Postgres, Unit tests, Integration tests.yml", "InitDev, MultiTenancy.yml") | ||
| $sha = "${{ github.event.workflow_run.head_sha }}" | ||
| Write-Host "sha is $sha" | ||
|
|
||
| Write-Host "Checking workflow statuses..." | ||
| $allSuccess = $true | ||
|
|
||
| foreach ($workflow in $workflowNames) { | ||
|
|
||
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS-Implementation/actions/workflows/$workflow/runs?head_sha=$sha" | ||
| $headers = @{ | ||
| Authorization = "Bearer $env:EDFI_ODS_TOKEN" | ||
| Accept = "application/vnd.github.v3+json" | ||
| } | ||
|
|
||
| $response = Invoke-RestMethod -Uri $url -Headers $headers | ||
|
|
||
| if ($response.workflow_runs.Count -eq 0) { | ||
| Write-Host "No runs found for workflow: $workflow" | ||
| $allSuccess = $false | ||
| break | ||
| } | ||
|
|
||
| $latestRun = $response.workflow_runs | Sort-Object -Property created_at -Descending | Select-Object -First 1 | ||
| if ($latestRun.conclusion -ne "success") { | ||
| Write-Host "latest Run status is $latestRun.status" | ||
| $allSuccess = $false | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if ($allSuccess) { | ||
| Write-Host "All workflows completed successfully." | ||
| break | ||
| } | ||
|
|
||
| if (-not $allSuccess) { | ||
| Write-Host "one or more workflows failed.So cancelling the build" | ||
| exit 1 | ||
| } | ||
| shell: pwsh | ||
| # Adding a step to ensure the build job fails if it was skipped | ||
| - name: Fail the build job if skipped | ||
| if: ${{ needs.FindStandardAndExtensionVersions.result == 'skipped' }} | ||
| run: | | ||
| echo "Build job was skipped due to a failure in the previous job." | ||
| exit 1 | ||
| shell: pwsh |
There was a problem hiding this comment.
These changes aren't needed since the GitHub action ahmadnassri/action-workflow-run-wait that we use below already does these checks internally.
We just need to remove the if from my previous comment so that the GitHub action gets executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.