Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the issue when connecting to the FTP using the port 21 over SSL && validating the if the File pattern is empty (Agent configuration) #55

Closed
wants to merge 2 commits into from

Conversation

mjimdev
Copy link
Contributor

@mjimdev mjimdev commented Feb 13, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stephenfuqua stephenfuqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjimdev thank you for submitting this PR! I two requests to help the code better fit with the Ed-Fi team's preferred C# style.

cc @jasonh-edfi

Copy link
Contributor

@jasonh-edfi jasonh-edfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and reviewed as switching from implicit to explicit FTPS handling and updated file handling

@jasonh-edfi jasonh-edfi self-requested a review April 9, 2024 21:02
Copy link
Contributor

@jasonh-edfi jasonh-edfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed after updates from SF and merged in

@stephenfuqua
Copy link
Contributor

@mjimdev please be sure to click the CLA badge to sign the contributor's license agreement.

@mjimdev mjimdev closed this by deleting the head repository Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants