[DMS-454] Add E2E OpenSearch and ElasticSearch to scheduled job #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpat-adam
force-pushed
the
DMS-454
branch
3 times, most recently
from
0828f6a to
d73f3d2
Compare
JBrenesSimpat
approved these changes
Jan 6, 2025
stephenfuqua
reviewed
Jan 6, 2025
| try { | ||
| Push-Location eng/docker-compose/ | ||
| ./start-local-dms.ps1 -d -v | ||
| ./start-local-dms.ps1 -SearchEngine "ElasticSearch" -d -v |
There was a problem hiding this comment.
@simpat-adam does this really require both lines? I would have thought line 256 was sufficient.
Is this running for if the search engine is "OpenSearch"?
There was a problem hiding this comment.
Yes, I have both because we run both open and elastic variants back to back and I didn't want to be locked into which order we run them in.
stephenfuqua
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.